-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ViewScene config as pop-up widgets #2318
Conversation
And quick screenshot improvement
Forgot to mention the new code uses some of https://github.com/commontk/CTK/, thanks to @jcfr for introducing it. |
I have a couple suggestions:
|
Autorotate stop/start is on the main button (the one with the icon) The rest I will add for sure! |
Few preliminary nitpicks:
|
I agree with both of those points. Reasoning behind the opposite decision: Our PR-review rate is extremely slow, so I tend to lump features and std-refactoring together. Ideally, I would submit multiple PRs on different branches, but if I did that the PRs would stack up even higher with likely a backlog of a year or more. Also, I tried setting up CTK as an external project, we have the cmake machinery for that, but I ran into several problems, which I've forgotten, so this is a "CTK-lite" attempt to just get a few widgets copied in. Normally I wouldn't do that either, but I was in a rush to start using them. See Qwt as an external--I've had many problems with that one over the years, and opted for fast-and-messy for this dependency. |
The ViewScene configuration window has been broken up into many small widgets that pop-up on hover/click of the now expanded ViewScene toolbar. The color GUI has also been much improved.
Additionally, the first step was taken to convert boost smart pointers to std smart pointers, by updating a typedef. And the C++ standard was set using modern CMake to C++17, which will obviate a few older compilers that a few users might have still been using.