Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boost naming for mac & unix debug builds #2317

Merged
merged 12 commits into from
Dec 20, 2021

Conversation

tarkpate
Copy link
Contributor

@tarkpate tarkpate commented Jul 26, 2021

The platform suffix was missing from the names.
Also for the non-python builds, 'y' needed to be removed from the debug postfix

Tested with & without python on mac and linux

@dcwhite dcwhite self-requested a review July 30, 2021 20:43
@dcwhite dcwhite self-assigned this Aug 2, 2021
@dcwhite dcwhite added this to the 5.0-beta.ϴ [Internal] milestone Aug 2, 2021
@dcwhite dcwhite added the Build label Aug 2, 2021
@dcwhite
Copy link
Member

dcwhite commented Aug 2, 2021

This will need lots of testing, and also after #2318

@dcwhite dcwhite requested review from jessdtate and GPayne October 1, 2021 20:28
Copy link
Member

@dcwhite dcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on M1 arm in release and debug, and both built fine (headless still, of course).

@dcwhite dcwhite merged commit d4884c6 into SCIInstitute:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants