-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gh 8835 move connectors adapters #8862
Feature/gh 8835 move connectors adapters #8862
Conversation
@@ -30,8 +33,4 @@ export * from './src/user/index'; | |||
export * from './src/util/index'; | |||
export * from './src/window/index'; | |||
|
|||
/** AUGMENTABLE_TYPES_START */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind bringing back the grouping of exports under the magic comment?
The order in this file is crucial for augmentable types feature to work (we run special post-builder for the types here under the magic comment) (see #7940). AFAIK it's used only in core public_api.ts
for now.
Btw. Thanks! You helped me notice how fragile is the mechanism and we will work on making it more bulletproof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good hint, thanks..This is due the auto import organize which I should not run here
Public API change detection bot@spartacus/assets public API diffnothing changed ;) @spartacus/storefront public API diff import { Route } from '@angular/router';
import { Router } from '@angular/router';
-import { RouterState } from '@spartacus/core';
import { RouterStateSnapshot } from '@angular/router';
import { RoutingConfig } from '@spartacus/core';
@@
// @public (undocumented)
-export namespace ConfigurationRouter {
- // (undocumented)
- export interface Data {
- // (undocumented)
- configuratorType?: string;
- // (undocumented)
- displayOnly?: boolean;
- // (undocumented)
- forceReload?: boolean;
- // (undocumented)
- isOwnerCartEntry?: boolean;
- // (undocumented)
- owner?: GenericConfigurator.Owner;
- // (undocumented)
- pageType?: PageType;
- // (undocumented)
- resolveIssues?: boolean;
- }
- // (undocumented)
- export enum PageType {
- // (undocumented)
- CONFIGURATION = "configuration",
- // (undocumented)
- OVERVIEW = "overview"
- }
-}
-
-// @public
-export class ConfiguratorRouterExtractorService {
- constructor(configUtilsService: GenericConfiguratorUtilsService, routingService: RoutingService);
- // (undocumented)
- protected configUtilsService: GenericConfiguratorUtilsService;
- // (undocumented)
- createOwnerFromRouterState(routerState: RouterState): GenericConfigurator.Owner;
- // (undocumented)
- extractRouterData(): Observable<ConfigurationRouter.Data>;
- protected getConfiguratorTypeFromSemanticRoute(semanticRoute: string): string;
- // (undocumented)
- protected readonly ROUTE_FRAGMENT_CONFIGURE = "configure";
- // (undocumented)
- protected readonly ROUTE_FRAGMENT_OVERVIEW = "configureOverview";
- // (undocumented)
- protected routingService: RoutingService;
-}
-
-// @public (undocumented)
export class ConfigureCartEntryComponent {
constructor(genericConfigUtilsService: GenericConfiguratorUtilsService, modalService: ModalService); @spartacus/cds public API diffnothing changed ;) @spartacus/core public API diffunable to analyze this library :( |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
No description provided.