-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for type augmentation #7940
Labels
team/blamed
Formerly known as Team Aimed and Team Framed; next it will be Team Famed?
team/obelix
type-augmentation
Milestone
Comments
dunqan
added
the
team/blamed
Formerly known as Team Aimed and Team Framed; next it will be Team Famed?
label
Jun 10, 2020
QA steps:
2, Confirm that augmenttion works (there is no compilation errors) for both dev and prod builds:
|
dunqan
added a commit
that referenced
this issue
Aug 11, 2020
dunqan
added a commit
that referenced
this issue
Aug 11, 2020
Allowing for the extensibility of our build-in core models helps in implementing a da- ta-driven approach for both our own libraries and 3rd party ones. As there are some well-known limitations in TypeScript around it, mentioned in those tickets: microsoft/TypeScript#9532 microsoft/TypeScript#18877 Spartacus uses additional build step for our libraries that will move augmentable models to main entry point generated by ng-packagr (eg spartacus-core.d.ts for core). Closes #7940
Would like to test this one :-) |
Test successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
team/blamed
Formerly known as Team Aimed and Team Framed; next it will be Team Famed?
team/obelix
type-augmentation
We should allow for the extensibility of our build-in types. Adding more properties for core models helps in implementing a data-driven approach for both our own libraries and 3rd party ones.
There are some well-known limitations in TypeScript around it, mentioned in those tickets:
export *
microsoft/TypeScript#9532The "plan of the attack" is:
ng-packagr
(egspartacus-core.d.ts
forcore
). It could be done by some additional utility script that will run after the build, by creating new builder extending default one or bay using some additional tools (like: https://www.npmjs.com/package/ng-cli-packagr-tasks)The text was updated successfully, but these errors were encountered: