Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use role button for carousel slide indicators #19790

Merged
merged 3 commits into from
Dec 20, 2024
Merged

fix: use role button for carousel slide indicators #19790

merged 3 commits into from
Dec 20, 2024

Conversation

sdrozdsap
Copy link
Contributor

@sdrozdsap sdrozdsap requested a review from a team as a code owner December 18, 2024 12:56
@github-actions github-actions bot marked this pull request as draft December 18, 2024 12:56
@sdrozdsap sdrozdsap marked this pull request as ready for review December 18, 2024 13:00
@cypress Cypress
Copy link

cypress bot commented Dec 18, 2024 •
edited
Loading

spartacus    Run #46448

Run Properties:  status check passed Passed #46448  •  git commit 086bdbca4e ℹ️: Merge a6f9f9db4b4b7e2e5251fa68a851a3bbc07bdf40 into 2ca33244ecc9ad23c677e2ec00e4...
Project spartacus
Branch Review bugfix/CXSPA-9000
Run status status check passed Passed #46448
Run duration 04m 04s
Commit git commit 086bdbca4e ℹ️: Merge a6f9f9db4b4b7e2e5251fa68a851a3bbc07bdf40 into 2ca33244ecc9ad23c677e2ec00e4...
Committer sdrozdsap
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft December 19, 2024 09:57
@sdrozdsap sdrozdsap marked this pull request as ready for review December 19, 2024 09:57
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 19, 2024 09:58
@sdrozdsap sdrozdsap marked this pull request as ready for review December 19, 2024 11:12
@github-actions github-actions bot marked this pull request as draft December 19, 2024 12:29
@sdrozdsap sdrozdsap marked this pull request as ready for review December 19, 2024 12:32
@github-actions github-actions bot marked this pull request as draft December 20, 2024 10:24
@sdrozdsap sdrozdsap marked this pull request as ready for review December 20, 2024 11:42
@sdrozdsap sdrozdsap merged commit cb8b1fd into develop Dec 20, 2024
28 checks passed
@sdrozdsap sdrozdsap deleted the bugfix/CXSPA-9000 branch December 20, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pio-Bar Pio-Bar Pio-Bar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdrozdsap @Pio-Bar