Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reset focus to the main after navigating #19694

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fix: reset focus to the main after navigating #19694

merged 3 commits into from
Dec 17, 2024

Conversation

sdrozdsap
Copy link
Contributor

@sdrozdsap sdrozdsap commented Dec 3, 2024 •
edited
Loading

@sdrozdsap sdrozdsap requested a review from a team as a code owner December 3, 2024 12:40
@github-actions github-actions bot marked this pull request as draft December 3, 2024 12:40
@sdrozdsap sdrozdsap marked this pull request as ready for review December 4, 2024 11:45
@cypress Cypress
Copy link

cypress bot commented Dec 4, 2024 •
edited
Loading

spartacus    Run #46405

Run Properties:  status check passed Passed #46405  •  git commit 7485a1cd16 ℹ️: Merge bc309939921256f7b167494413231346958f1c98 into 79ad9117978a04d21f19789c576c...
Project spartacus
Branch Review bugfix/CXSPA-9056
Run status status check passed Passed #46405
Run duration 04m 00s
Commit git commit 7485a1cd16 ℹ️: Merge bc309939921256f7b167494413231346958f1c98 into 79ad9117978a04d21f19789c576c...
Committer sdrozdsap
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft December 5, 2024 08:41
@sdrozdsap sdrozdsap marked this pull request as ready for review December 5, 2024 08:42
@sdrozdsap sdrozdsap changed the title feat: Reset focus to the main after navigating feat: reset focus to the main after navigating Dec 5, 2024
@sdrozdsap sdrozdsap requested a review from Zeyber December 5, 2024 08:53
Zeyber
Zeyber previously approved these changes Dec 5, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 5, 2024 10:51
@sdrozdsap sdrozdsap marked this pull request as ready for review December 5, 2024 10:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

developpeurweb
developpeurweb previously approved these changes Dec 5, 2024
View reviewed changes
@github-actions github-actions bot marked this pull request as draft December 6, 2024 15:14
@sdrozdsap sdrozdsap marked this pull request as ready for review December 6, 2024 15:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@sdrozdsap sdrozdsap dismissed stale reviews from Zeyber and developpeurweb via fabd7b6 December 6, 2024 16:13
@github-actions github-actions bot marked this pull request as draft December 6, 2024 16:13
@sdrozdsap sdrozdsap marked this pull request as ready for review December 6, 2024 16:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 6, 2024 16:54
@sdrozdsap sdrozdsap marked this pull request as ready for review December 6, 2024 16:55
@sdrozdsap sdrozdsap changed the title feat: reset focus to the main after navigating fix: reset focus to the main after navigating Dec 6, 2024
developpeurweb
developpeurweb previously approved these changes Dec 6, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 9, 2024 11:51
@sdrozdsap sdrozdsap marked this pull request as ready for review December 9, 2024 11:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 9, 2024 12:40
@sdrozdsap sdrozdsap marked this pull request as ready for review December 9, 2024 13:05
@github-actions github-actions bot marked this pull request as draft December 17, 2024 13:27
@sdrozdsap sdrozdsap marked this pull request as ready for review December 17, 2024 13:27
@github-actions github-actions bot marked this pull request as draft December 17, 2024 14:15
@sdrozdsap sdrozdsap marked this pull request as ready for review December 17, 2024 14:15
@github-actions github-actions bot marked this pull request as draft December 17, 2024 14:40
@sdrozdsap sdrozdsap marked this pull request as ready for review December 17, 2024 15:01
@sdrozdsap sdrozdsap merged commit f232f4d into develop Dec 17, 2024
28 checks passed
@sdrozdsap sdrozdsap deleted the bugfix/CXSPA-9056 branch December 17, 2024 15:30
sdrozdsap added a commit that referenced this pull request Dec 19, 2024
@sdrozdsap
fix: reset focus to the main after navigating (#19694)
4409b83
sdrozdsap added a commit that referenced this pull request Dec 19, 2024
@sdrozdsap
fix: reset focus to the main after navigating (#19694)
71ac007
anjana-bl pushed a commit that referenced this pull request Jan 9, 2025
@sdrozdsap @anjana-bl
fix: reset focus to the main after navigating (#19694)
681b07b
Pio-Bar pushed a commit that referenced this pull request Jan 9, 2025
@sdrozdsap @Pio-Bar
fix: reset focus to the main after navigating (#19694)
c251bc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pio-Bar Pio-Bar Pio-Bar approved these changes

@developpeurweb developpeurweb developpeurweb left review comments

@Zeyber Zeyber Zeyber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdrozdsap @Zeyber @developpeurweb @Pio-Bar