Epic: CXSPA-2897

[ercultimate]

• throwError is replaced with throw.

Original: catchError((error: any) => throwError(normalizeHttpError(error))
Replacement:  catchError((error: any) => {
        throw normalizeHttpError(error, this.logger);
      }) 

In unit-tests:

Original: throwError({ details: [{ message: expectedErrorMessage }] }) 
Replacement: throwError(() => ({ details: [{ message: expectedErrorMessage }] }))

• Deprecated publishReplay().
  Use the connectable observable, the connect operator. 
  Use case: Pull Request #17387

• Deprecated retryWhen(). Use retry with delay instead.
  Use case: Pull Request #17385

• Deprecated Subject.hasError | isStopped:
  Example of replacement: Pull Request #17390.

• The toPromise() function is now deprecated.
  Example of replacement: Pull Request #17383.

• Tap - In RxJS v7.3, the "tap" operator introduces three new handlers: unsubscribe, subscribe, and finalize. If these handlers are not selectively specified, all of them are implicitly forwarded.
  example: https://github.com/SAP/spartacus/pull/17904/files#diff-80faeb8c67829409d03e3f52695b7fe038c4f351c667e32db16ef73e53ef9368R78

[cypress]

4 flaky tests on run #40284 ↗︎

0

706

29

0

4

Details:

chore: cleanup deprecated `throwError()` (#17386)
Project: spartacus	Commit: 0599c86184
Status: Passed	Duration: 16:48 💡
Started: May 11, 2023 3:25 PM	Ended: May 11, 2023 3:42 PM

  regression/save-for-later/save-for-later.e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test		Artifacts
... > should save for later/move to cart for items		Output Screenshots

  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test		Artifacts
SSR > should render homepage		Output Screenshots
SSR > should render PLP		Output Screenshots
SSR > should render PDP		Output Screenshots

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[cla-assistant]

All committers have signed the CLA.

[cypress]

6 flaky tests on run #41707 ↗︎

0

739

25

0

6

Details:

Merge 9a6ef32 into 9090f16...
Project: spartacus	Commit: 27ba13982b ℹ️
Status: Passed	Duration: 17:18 💡
Started: Oct 23, 2023 3:15 PM	Ended: Oct 23, 2023 3:33 PM

  regression/asm/asm.deeplink.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test		Artifacts
Assisted Service Module > Customer Support Agent - Emulation&deeplink > should emulate customer and navigate to support ticket with deeplink after agent login (CXSPA-3263)		Test Replay Output Screenshots Video

  regression/cart/saved-cart.e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test		Artifacts
... > should make cart active and not swap cart when active cart is empty, and clone saved cart with new cart name		Test Replay Output Screenshots Video

  regression/checkout/checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test		Artifacts
Checkout flow > Desktop > should checkout with a registered user by searching a product		Test Replay Output Screenshots Video

  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test		Artifacts
SSR > should render homepage		Test Replay Output Screenshots Video
SSR > should render PLP		Test Replay Output Screenshots Video
SSR > should render PDP		Test Replay Output Screenshots Video

Review all test suite changes for PR #17399 ↗︎

[pawelfras]

LGTM. One thing I propose to add is a meaningful and exhausting description of what was changed and what issues we faced.