CXSPA-3073: RxJs 7 #17362
Merged
CXSPA-3073: RxJs 7 #17362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update jasmine-marbles from 0.6 to 0.9
ercultimate
force-pushed
the
feature/CXSPA-3073
branch
from
488080c to
a8f4931
Compare
In RxJs 6, debounce emits when the inner observable emits _or completes_. In RxJs 7, debounce emits when the inner observable emits.
The resolve type of `Observable.toPromise()` was updated to include undefined, which would be the case if the observable did not emit. Using `fromLastValue` gurantees the resolve type by rejecting in the case of no emit when the observable closes.
ercultimate
force-pushed
the
feature/CXSPA-3073
branch
from
a8f4931 to
5e6da17
Compare
WeizhengSap
reviewed
May 5, 2023
| @@ -76,7 +76,7 @@ export class MultiCartService implements MultiCartFacade { | |||
| // This flickering should only be avoided when switching from false to true | |||
| // Start of loading should be showed instantly (no debounce) | |||
| // Extra actions are only dispatched after some loading | |||
| debounce((isStable) => (isStable ? timer(0) : EMPTY)), | |||
| debounce((isStable) => (isStable ? timer(0) : of(undefined))), | |||
There was a problem hiding this comment.
See commit fix undocumented behavior change in debounce
WeizhengSap
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.