fix(http): Use configured logger for retryClient #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFenner
approved these changes
Sep 6, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
2 tasks
|
/it-go |
1 similar comment
|
/it-go |
|
/it-go |
|
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
Oct 1, 2024
* origin/master: (35 commits) feat(notification): Notify in case of Release failure (SAP#5045) fix(docs): remove dead links (SAP#5051) chore: remove obsolete cloud sdk conversion file (SAP#5036) feat: fail if script is not found in package.json file (SAP#5029) feat(sonar): Enable trustengine for token retrieval (SAP#5046) feat(trustengine): Add new resource reference to parameter docs generation (SAP#5038) docs: add unit test tags flag (SAP#4947) CONTRIBUTING.md (SAP#5042) addon.yml may now contain wildCard MAXX (SAP#5039) fix(codeqlExecuteScan): handle spaces in path to maven settings file (SAP#5037) feat(trustengine): Integrate Trust Engine into step config resolver (SAP#5032) fix(http): Use configured logger for retryClient (SAP#5040) Updated helm.sh/helm from 13.14.0 to 13.14.2 (SAP#5041) Copy full project (SAP#5033) feat(vault): support complex data types in secrets (SAP#5006) Added pagination logic for retrieving projects from Black Duck server (SAP#5031) Update aws deps (SAP#5034) Add possible values and default (SAP#5030) Fix security issues reported by Black Duck (SAP#5014) Exposing build artifact metadata from maven and npm (SAP#5008) ...
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
Oct 1, 2024
…fig-fix * origin/master: (35 commits) feat(notification): Notify in case of Release failure (SAP#5045) fix(docs): remove dead links (SAP#5051) chore: remove obsolete cloud sdk conversion file (SAP#5036) feat: fail if script is not found in package.json file (SAP#5029) feat(sonar): Enable trustengine for token retrieval (SAP#5046) feat(trustengine): Add new resource reference to parameter docs generation (SAP#5038) docs: add unit test tags flag (SAP#4947) CONTRIBUTING.md (SAP#5042) addon.yml may now contain wildCard MAXX (SAP#5039) fix(codeqlExecuteScan): handle spaces in path to maven settings file (SAP#5037) feat(trustengine): Integrate Trust Engine into step config resolver (SAP#5032) fix(http): Use configured logger for retryClient (SAP#5040) Updated helm.sh/helm from 13.14.0 to 13.14.2 (SAP#5041) Copy full project (SAP#5033) feat(vault): support complex data types in secrets (SAP#5006) Added pagination logic for retrieving projects from Black Duck server (SAP#5031) Update aws deps (SAP#5034) Add possible values and default (SAP#5030) Fix security issues reported by Black Duck (SAP#5014) Exposing build artifact metadata from maven and npm (SAP#5008) ...
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
Oct 1, 2024
…ix-fix * origin/master: (35 commits) feat(notification): Notify in case of Release failure (SAP#5045) fix(docs): remove dead links (SAP#5051) chore: remove obsolete cloud sdk conversion file (SAP#5036) feat: fail if script is not found in package.json file (SAP#5029) feat(sonar): Enable trustengine for token retrieval (SAP#5046) feat(trustengine): Add new resource reference to parameter docs generation (SAP#5038) docs: add unit test tags flag (SAP#4947) CONTRIBUTING.md (SAP#5042) addon.yml may now contain wildCard MAXX (SAP#5039) fix(codeqlExecuteScan): handle spaces in path to maven settings file (SAP#5037) feat(trustengine): Integrate Trust Engine into step config resolver (SAP#5032) fix(http): Use configured logger for retryClient (SAP#5040) Updated helm.sh/helm from 13.14.0 to 13.14.2 (SAP#5041) Copy full project (SAP#5033) feat(vault): support complex data types in secrets (SAP#5006) Added pagination logic for retrieving projects from Black Duck server (SAP#5031) Update aws deps (SAP#5034) Add possible values and default (SAP#5030) Fix security issues reported by Black Duck (SAP#5014) Exposing build artifact metadata from maven and npm (SAP#5008) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the current implementation, a
loggerthat is set throughclient.SetOptions()is overridden when retries are configured (which by default is the case). This only seems to be done to setlogrus.DebugLevel.The result of this is that the
retryClientwill always output some logs, and it's impossible to pass a logger withlogger.SetOutput(io.Discard)that prevents these logs from being generated.If no logger is explicitly configured for a
retryClient(which is mostly the case), theverbosesetting of theconfig.ymlis already respected anyway, sincelog.Entry()is then used to set a logger.