Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy projects with symlinks #5033

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Copy projects with symlinks #5033

merged 1 commit into from
Sep 6, 2024

Conversation

modulo11
Copy link
Member

@modulo11 modulo11 commented Aug 30, 2024 •
edited
Loading

Changes

Not ready for review.

  • Tests
  • Documentation

@modulo11 modulo11 requested review from a team as code owners August 30, 2024 10:35
@modulo11
Copy link
Member Author

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from 5f12ba8 to 44e6920 Compare August 30, 2024 10:48
@modulo11
Copy link
Member Author

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from 44e6920 to a8ad0a4 Compare August 30, 2024 11:27
@modulo11
Copy link
Member Author

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from a8ad0a4 to 59c0d45 Compare August 30, 2024 12:14
@modulo11
Copy link
Member Author

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch 2 times, most recently from d2bb1cc to 4e10f9f Compare September 3, 2024 06:55
@modulo11
Copy link
Member Author

modulo11 commented Sep 3, 2024

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from 4e10f9f to b229462 Compare September 3, 2024 08:36
@modulo11
Copy link
Member Author

modulo11 commented Sep 3, 2024

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from b229462 to e94d01b Compare September 3, 2024 08:48
@modulo11
Copy link
Member Author

modulo11 commented Sep 3, 2024

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch 2 times, most recently from e9f8726 to 6e0cb74 Compare September 3, 2024 11:27
@modulo11
Copy link
Member Author

modulo11 commented Sep 3, 2024

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from 6e0cb74 to 414ad1a Compare September 4, 2024 11:00
@modulo11
Copy link
Member Author

modulo11 commented Sep 4, 2024

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from 414ad1a to 16a516f Compare September 4, 2024 12:38
@modulo11
Copy link
Member Author

modulo11 commented Sep 4, 2024

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from 16a516f to b0b5643 Compare September 4, 2024 13:00
@modulo11
Copy link
Member Author

modulo11 commented Sep 4, 2024

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from b0b5643 to 61a5c43 Compare September 4, 2024 13:55
c0d1ngm0nk3y
c0d1ngm0nk3y reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@c0d1ngm0nk3y c0d1ngm0nk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch 3 times, most recently from 678a31e to fc3fe99 Compare September 5, 2024 12:45
@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch 3 times, most recently from f12720b to 13fdf8c Compare September 5, 2024 15:29
@modulo11
Copy link
Member Author

modulo11 commented Sep 5, 2024

/it-go

1 similar comment
@modulo11
Copy link
Member Author

modulo11 commented Sep 6, 2024

/it-go

c0d1ngm0nk3y
c0d1ngm0nk3y reviewed Sep 6, 2024
View reviewed changes
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from 97a57a9 to 5f6344b Compare September 6, 2024 09:12
@modulo11
Copy link
Member Author

modulo11 commented Sep 6, 2024

/it-go

c0d1ngm0nk3y
c0d1ngm0nk3y approved these changes Sep 6, 2024
View reviewed changes
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
pkg/cnbutils/copy_project.go Outdated Show resolved Hide resolved
@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from 5f6344b to ba327bf Compare September 6, 2024 10:43
@modulo11 modulo11 enabled auto-merge (squash) September 6, 2024 10:43
@modulo11
Copy link
Member Author

modulo11 commented Sep 6, 2024

/it-go

@modulo11 modulo11 force-pushed the cnb-copy-with-symlinks branch from ba327bf to 2971a53 Compare September 6, 2024 12:03
@modulo11
Copy link
Member Author

modulo11 commented Sep 6, 2024

/it-go

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@modulo11
Copy link
Member Author

modulo11 commented Sep 6, 2024

/it-go

@modulo11 modulo11 merged commit 34f1057 into master Sep 6, 2024
12 checks passed
@modulo11 modulo11 deleted the cnb-copy-with-symlinks branch September 6, 2024 12:27
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Oct 1, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into malwarescan-async-scan
802634c 
* origin/master: (35 commits)
  feat(notification): Notify in case of Release failure (SAP#5045)
  fix(docs): remove dead links (SAP#5051)
  chore: remove obsolete cloud sdk conversion file (SAP#5036)
  feat: fail if script is not found in package.json file (SAP#5029)
  feat(sonar): Enable trustengine for token retrieval (SAP#5046)
  feat(trustengine): Add new resource reference to parameter docs generation (SAP#5038)
  docs: add unit test tags flag (SAP#4947)
  CONTRIBUTING.md (SAP#5042)
  addon.yml may now contain wildCard MAXX (SAP#5039)
  fix(codeqlExecuteScan): handle spaces in path to maven settings file (SAP#5037)
  feat(trustengine): Integrate Trust Engine into step config resolver (SAP#5032)
  fix(http): Use configured logger for retryClient (SAP#5040)
  Updated helm.sh/helm from 13.14.0 to 13.14.2 (SAP#5041)
  Copy full project (SAP#5033)
  feat(vault): support complex data types in secrets (SAP#5006)
  Added pagination logic for retrieving projects from Black Duck server (SAP#5031)
  Update aws deps (SAP#5034)
  Add possible values and default (SAP#5030)
  Fix security issues reported by Black Duck (SAP#5014)
  Exposing build artifact metadata from maven and npm  (SAP#5008)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Oct 1, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into whitesource-sbt-con…
5c5c7e6 
…fig-fix

* origin/master: (35 commits)
  feat(notification): Notify in case of Release failure (SAP#5045)
  fix(docs): remove dead links (SAP#5051)
  chore: remove obsolete cloud sdk conversion file (SAP#5036)
  feat: fail if script is not found in package.json file (SAP#5029)
  feat(sonar): Enable trustengine for token retrieval (SAP#5046)
  feat(trustengine): Add new resource reference to parameter docs generation (SAP#5038)
  docs: add unit test tags flag (SAP#4947)
  CONTRIBUTING.md (SAP#5042)
  addon.yml may now contain wildCard MAXX (SAP#5039)
  fix(codeqlExecuteScan): handle spaces in path to maven settings file (SAP#5037)
  feat(trustengine): Integrate Trust Engine into step config resolver (SAP#5032)
  fix(http): Use configured logger for retryClient (SAP#5040)
  Updated helm.sh/helm from 13.14.0 to 13.14.2 (SAP#5041)
  Copy full project (SAP#5033)
  feat(vault): support complex data types in secrets (SAP#5006)
  Added pagination logic for retrieving projects from Black Duck server (SAP#5031)
  Update aws deps (SAP#5034)
  Add possible values and default (SAP#5030)
  Fix security issues reported by Black Duck (SAP#5014)
  Exposing build artifact metadata from maven and npm  (SAP#5008)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Oct 1, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into kaniko-context-pref…
486eb9c 
…ix-fix

* origin/master: (35 commits)
  feat(notification): Notify in case of Release failure (SAP#5045)
  fix(docs): remove dead links (SAP#5051)
  chore: remove obsolete cloud sdk conversion file (SAP#5036)
  feat: fail if script is not found in package.json file (SAP#5029)
  feat(sonar): Enable trustengine for token retrieval (SAP#5046)
  feat(trustengine): Add new resource reference to parameter docs generation (SAP#5038)
  docs: add unit test tags flag (SAP#4947)
  CONTRIBUTING.md (SAP#5042)
  addon.yml may now contain wildCard MAXX (SAP#5039)
  fix(codeqlExecuteScan): handle spaces in path to maven settings file (SAP#5037)
  feat(trustengine): Integrate Trust Engine into step config resolver (SAP#5032)
  fix(http): Use configured logger for retryClient (SAP#5040)
  Updated helm.sh/helm from 13.14.0 to 13.14.2 (SAP#5041)
  Copy full project (SAP#5033)
  feat(vault): support complex data types in secrets (SAP#5006)
  Added pagination logic for retrieving projects from Black Duck server (SAP#5031)
  Update aws deps (SAP#5034)
  Add possible values and default (SAP#5030)
  Fix security issues reported by Black Duck (SAP#5014)
  Exposing build artifact metadata from maven and npm  (SAP#5008)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbender nicolasbender nicolasbender approved these changes

@c0d1ngm0nk3y c0d1ngm0nk3y c0d1ngm0nk3y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modulo11 @c0d1ngm0nk3y @nicolasbender