Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce filterRegex parameter for performance report publisher #4555

Merged
merged 12 commits into from
Oct 11, 2023
35 changes: 18 additions & 17 deletions documentation/docs/steps/testsPublishResults.md
Original file line number Diff line number Diff line change
@@ -58,24 +58,25 @@ testsPublishResults(

### jmeter

| parameter | mandatory | default | possible values |
| ----------|-----------|---------|-----------------|
| parameter | mandatory | default | possible values |
| ----------|-----------|--------------|-----------------|
| pattern | no | `'**/*.jtl'` | |
| errorFailedThreshold | no | `20` | |
| errorUnstableThreshold | no | `10` | |
| errorUnstableResponseTimeThreshold | no | `` | |
| relativeFailedThresholdPositive | no | `0` | |
| relativeFailedThresholdNegative | no | `0` | |
| relativeUnstableThresholdPositive | no | `0` | |
| relativeUnstableThresholdNegative | no | `0` | |
| modeOfThreshold | no | `false` | true, false |
| modeThroughput | no | `false` | true, false |
| nthBuildNumber | no | `0` | |
| configType | no | `PRT` | |
| failBuildIfNoResultFile | no | `false` | true, false |
| compareBuildPrevious | no | `true` | true, false |
| archive | no | `false` | true, false |
| allowEmptyResults | no | `true` | true, false |
| errorFailedThreshold | no | `20` | |
| errorUnstableThreshold | no | `10` | |
| errorUnstableResponseTimeThreshold | no | `` | |
| relativeFailedThresholdPositive | no | `0` | |
| relativeFailedThresholdNegative | no | `0` | |
| relativeUnstableThresholdPositive | no | `0` | |
| relativeUnstableThresholdNegative | no | `0` | |
| modeOfThreshold | no | `false` | true, false |
| modeThroughput | no | `false` | true, false |
| nthBuildNumber | no | `0` | |
| configType | no | `PRT` | |
| failBuildIfNoResultFile | no | `false` | true, false |
| compareBuildPrevious | no | `true` | true, false |
| archive | no | `false` | true, false |
| allowEmptyResults | no | `true` | true, false |
| filterRegex | no | ' ' | |

## ${docGenConfiguration}

1 change: 1 addition & 0 deletions resources/default_pipeline_environment.yml
Original file line number Diff line number Diff line change
@@ -481,6 +481,7 @@ steps:
active: false
jmeter:
pattern: '**/*.jtl'
filterRegex: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a quick question this filterRegex would also needed to be added to the piper defaults when using the sap specefic defaults ?. that comes from a different repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anilkeshav27 It probably should be. But why is a step loading values from two different configs ? Aren't certain steps meant to be coming from the piper-lib-os and not the internal one ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errorFailedThreshold: 20
errorUnstableThreshold: 10
errorUnstableResponseTimeThreshold: ''
3 changes: 2 additions & 1 deletion vars/testsPublishResults.groovy
Original file line number Diff line number Diff line change
@@ -163,7 +163,8 @@ def publishJMeterReport(Map settings = [:]){
nthBuildNumber: settings.get('nthBuildNumber'),
configType: settings.get('configType'),
failBuildIfNoResultFile: settings.get('failBuildIfNoResultFile'),
compareBuildPrevious: settings.get('compareBuildPrevious')
compareBuildPrevious: settings.get('compareBuildPrevious'),
filterRegex: settings.get('filterRegex')
)
archiveResults(settings.get('archive'), pattern, settings.get('allowEmptyResults'))
}