Introduce filterRegex parameter for performance report publisher #4555
Conversation
Add filterRegex parameter to jmeter configuration. Set it to an empty string as generated from pipelinesyntax reference in jenkins
Add the filterRegex param to the publishJmeterReport plugin in testPublishResults
|
/it-go |
|
@CCFenner @anilkeshav27 Can someone take a look at this ? |
|
@ashlymat Can someone from the piper community please help merge this change? |
|
@sumeetpatil @OliverNocon Can someone from the code owners please look at this. |
| @@ -481,6 +481,7 @@ steps: | |||
| active: false | |||
| jmeter: | |||
| pattern: '**/*.jtl' | |||
| filterRegex: '' | |||
There was a problem hiding this comment.
a quick question this filterRegex would also needed to be added to the piper defaults when using the sap specefic defaults ?. that comes from a different repo
There was a problem hiding this comment.
@anilkeshav27 It probably should be. But why is a step loading values from two different configs ? Aren't certain steps meant to be coming from the piper-lib-os and not the internal one ?
There was a problem hiding this comment.
|
Kudos, SonarCloud Quality Gate passed!
|
|
/it-go |
…#4555) * Update default_pipeline_environment.yml Add filterRegex parameter to jmeter configuration. Set it to an empty string as generated from pipelinesyntax reference in jenkins * Update testsPublishResults.groovy Add the filterRegex param to the publishJmeterReport plugin in testPublishResults * Update documentation to include filterRegex --------- Co-authored-by: Anil Keshav <[email protected]>
* Update default_pipeline_environment.yml Add filterRegex parameter to jmeter configuration. Set it to an empty string as generated from pipelinesyntax reference in jenkins * Update testsPublishResults.groovy Add the filterRegex param to the publishJmeterReport plugin in testPublishResults * Update documentation to include filterRegex --------- Co-authored-by: Anil Keshav <[email protected]>
…#4555) * Update default_pipeline_environment.yml Add filterRegex parameter to jmeter configuration. Set it to an empty string as generated from pipelinesyntax reference in jenkins * Update testsPublishResults.groovy Add the filterRegex param to the publishJmeterReport plugin in testPublishResults * Update documentation to include filterRegex --------- Co-authored-by: Anil Keshav <[email protected]>
Changes
Step
testsPublishResultsuse the performance plugin from jenkins to publish jmeter reports. It is possible to set thresholds per test and fail pipelines if they exceed. This feature was broken as the parameterfilterRegexwas not defined in piper-defaults and was always evaluating tonull.Error observed in pipelines before the change
With these changes, the plugin is able to set the threshold and parse the file. Working output below
This step and the feature from the performance plugin is actively used by our teams to notify on performance degradation for our services.