Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHKO: Change remoteEnabled flag to checkType enum #275

Merged
merged 15 commits into from
Dec 20, 2021
Merged

CHKO: Change remoteEnabled flag to checkType enum #275

merged 15 commits into from
Dec 20, 2021

Conversation

burcuka
Copy link
Contributor

@burcuka burcuka commented Dec 16, 2021

No description provided.

schneidermic0
schneidermic0 approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@albertmink
Copy link
Contributor

And removes 'technical_id' :)

albertmink
albertmink requested changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions are non-titlecase.

@albertmink albertmink linked an issue Dec 16, 2021 that may be closed by this pull request
CHKO: open questions #138
Closed
@burcuka burcuka requested a review from albertmink December 17, 2021 09:21
albertmink
albertmink requested changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I found another case miss match 😇

file-formats/chko/type/zif_aff_chko_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/chko/chko-v1.json Outdated Show resolved Hide resolved
@burcuka burcuka merged commit 38da486 into main Dec 20, 2021
@burcuka burcuka deleted the aff branch December 20, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneidermic0 schneidermic0 schneidermic0 approved these changes

@albertmink albertmink albertmink approved these changes

@wurzka wurzka Awaiting requested review from wurzka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CHKO: open questions
3 participants
@burcuka @albertmink @schneidermic0