Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHKO: open questions #138

Closed
larshp opened this issue Jul 23, 2021 · 7 comments · Fixed by #275
Closed

CHKO: open questions #138

larshp opened this issue Jul 23, 2021 · 7 comments · Fixed by #275
Assignees

Comments

@larshp
Copy link
Collaborator

larshp commented Jul 23, 2021

A: is the name unique?
Looking at the data format, there can be multiple identical names?

B: name should be string?
Looking at the database definition, the name is a string?

C: translation of parameters missing

D: "modifiable" vs "hidden", the screenshot in https://blogs.sap.com/2021/05/25/how-to-create-your-own-atc-check-in-sap-btp-abap-environment/ says hidden, the format modifiable?
image

@schneidermic0
Copy link
Contributor

schneidermic0 commented Jul 23, 2021

A: Yes the parameter name should be unique. Do you mean the uniqueItems should be set for the parameters array? see also #120

B: It's a char 30 field? See here. What would you expect here?

C: Yes, this is related to #106

D: I agree, we should double check whether hidden would be better

@larshp
Copy link
Collaborator Author

larshp commented Jul 23, 2021

A: if the name is unique, then the technical_id can be removed, not sure if it should. Its part of persistence, but not presented to the developer?

B: looking at the database, its a string?
image

@schneidermic0
Copy link
Contributor

A+B: OK, I see your point. I'll check it with the team

@albertmink
Copy link
Contributor

Answer for A, B and D in #139

For C it is referred to #106

@larshp
Copy link
Collaborator Author

larshp commented Jul 29, 2021

  • Use types close to the database types
  • Use terminology as presented to the developer

@schneidermic0
Copy link
Contributor

A: I talked to the developers responsible for CHKO. techincalId is basically obsolet, but an implementation still relies on it. They try to remove the dependency so that we can also remove the techincalId.

@albertmink

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants