Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated json, set uniqueItems to true for all arrays #120

Closed
larshp opened this issue Jul 16, 2021 · 5 comments · Fixed by #226
Closed

generated json, set uniqueItems to true for all arrays #120

larshp opened this issue Jul 16, 2021 · 5 comments · Fixed by #226
Labels
decided Design decision made. Implementation by SAP is open onlySAP Can be implemented by SAP only

Comments

@larshp
Copy link
Collaborator

larshp commented Jul 16, 2021

Hi,
I think its safe to set uniqueItems for all arrays?

https://json-schema.org/understanding-json-schema/reference/array.html#uniqueness

@schneidermic0
Copy link
Contributor

schneidermic0 commented Jul 19, 2021

Yes, I agree. I think we can add this to our schema generator. If we see that there are use cases for non-unique items we can react on this.

@larshp larshp added the onlySAP Can be implemented by SAP only label Jul 19, 2021
@larshp
Copy link
Collaborator Author

larshp commented Jul 19, 2021

it's only possible for SAP to implement this issue, as the code for JSON generation is proprietary

@larshp
Copy link
Collaborator Author

larshp commented Jul 19, 2021

actually, see #126, its not relevant for all internal tables, but if there is a unique key defined it should be okay to add uniqueItems

@schneidermic0
Copy link
Contributor

schneidermic0 commented Jul 19, 2021

... but if there is a unique key defined it should be okay to add uniqueItems

Good point, thanks!

@schneidermic0
Copy link
Contributor

schneidermic0 commented Jul 19, 2021

I have talked to the team, today. It agrees to add a uniqueItems.

@schneidermic0 schneidermic0 self-assigned this Jul 19, 2021
@schneidermic0 schneidermic0 removed their assignment Aug 16, 2021
@schneidermic0 schneidermic0 added the decided Design decision made. Implementation by SAP is open label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decided Design decision made. Implementation by SAP is open onlySAP Can be implemented by SAP only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants