Add interface for types used by CLAS & INTF #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface zif_oo_aff_types_v1 was added
|
the linter doesnt find the file, need to define a folder structure #109 |
|
@larshp thank you for your help! |
|
@crasovan and I, we decided to move the types used both by INTF and by CLAS into one common interface. |
schneidermic0
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Yes, this makes sense to me to introduce reusable types. Maybe we have to change the interface name in the future. See #128.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface zif_oo_aff_types_v1 was added