-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder structure #109
Comments
alternatively, move the ABAP type to the same folder level as the generated JSON |
We could start with option B. The folder name would suggest not to edit the json-schema manually as raised in #110. |
As long as we keep the reference to the schema file (jn the I would prefer not to use the interface name for the json-schema file. At least as long as we are referring to it in the files. But we should add the version (like But, maybe, it makes sense to move all generated json schemas to one dedicated folder and keep the folder structure of object types only for the ABAP types, the format documentation and the example. E.g., |
I'd like to remove the |
Let's continue with this issue as soon as #53 is solved. |
Update:
I feel as if the above discussion is outdated, due to the evolution of the repository and will close the issue. |
Example: https://github.com/SAP/abap-file-formats/tree/main/file-formats/chkc
it contains
the source is under
type
and the first file in the folder is the auto generated json schema fileSuggest:
A: Move the ABAP source to the root of the object type folder
B: Move the auto generated json schema to a new folder
generated
under the object typeC: Change the filename of the auto generated json schema, eg
zif_atc_aff_chkc_v1.json
to make it easier for users to tell the relationship between filesThe text was updated successfully, but these errors were encountered: