Make RsaPrivateKey::from_components fallible
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an error case in the event the number of `primes` provides is fewer than 2, which prevents panics when invoking methods which expect primes to always be present at indices 0 and 1 (i.e. `p` and `q`) Fixes #163
tarcieri
commented
Jul 24, 2022
Comment on lines
+67
to
+68
| [profile.dev] | ||
| opt-level = 2 |
There was a problem hiding this comment.
Threw this in there too. It significantly speeds up non-release tests.
|
We could also add a check that the modulus is under some prescribed sanity limit (e.g. 16384 bits) |
Yes, there should definitely be a sanity check. E.g. because of #166 since this would probably work with private keys too. |
Lets do that together with the compile time flags though, as that will be a (bigger) breaking change |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an error case in the event the number of
primesprovides is fewer than 2, which prevents panics when invoking methods which expect primes to always be present at indices 0 and 1 (i.e.pandq)Fixes #163