Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of RSA from_components to support Result. #42

Closed
VocalFan opened this issue Nov 3, 2022 · 2 comments
Closed

Fix implementation of RSA from_components to support Result. #42

VocalFan opened this issue Nov 3, 2022 · 2 comments
Assignees
@VocalFan
Labels
T-bug Type: Bug
Milestone
PKG Installer

Comments

@VocalFan
Copy link
Member

VocalFan commented Nov 3, 2022

In order to be able to upgrade to RSA 0.7, we need to be able to handle the fallible error for primes. The PR that caused this addition is here: RustCrypto/RSA#167
@ultimaweapon
Copy link
Member

In our case the returned Result can be ignored with unwrap because the supplied value is hard-coded, which is a valid value.

@VocalFan VocalFan self-assigned this Nov 7, 2022
@VocalFan
Copy link
Member Author

VocalFan commented Nov 7, 2022

In our case the returned Result can be ignored with unwrap because the supplied value is hard-coded, which is a valid value.

Fixed! :3

@VocalFan VocalFan closed this as completed Nov 7, 2022
@ultimaweapon ultimaweapon added this to the PKG Installer milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VocalFan VocalFan

Labels
T-bug Type: Bug
Milestone
PKG Installer
Development

No branches or pull requests
2 participants
@ultimaweapon @VocalFan