Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: Stop testing 'hmac' on 1.21 #20

Merged
merged 1 commit into from
Aug 25, 2019

Conversation

tarcieri
Copy link
Member

CI is broken (ostensibly also for master) because typenum switched to using nested import braces, which are unsupported on 1.21:

https://travis-ci.org/RustCrypto/MACs/jobs/576563817

So it seems 1.21 is below typenum's MSRV. Since we plan on bumping MSRV anyway, this removes the tests for 1.21 so master CI passes again.

CI is broken (ostensibly also for `master`) because `typenum` switched
to using nested import braces, which are unsupported on 1.21:

https://travis-ci.org/RustCrypto/MACs/jobs/576563817

So it seems 1.21 is below typenum's MSRV. Since we plan on bumping MSRV
anyway, this removes the tests for 1.21 so `master` CI passes again.
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welll, so much for keeping MSRV... :/ We probably will have to update other affected repositories as well.

@tarcieri tarcieri merged commit b46b8de into master Aug 25, 2019
@tarcieri tarcieri deleted the hmac/drop-ci-for-rust-1-21 branch August 25, 2019 22:27
@newpavlov
Copy link
Member

@tarcieri
typenum has removed nested imports, so I think we can revert this change.

@tarcieri
Copy link
Member Author

Reverted in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants