Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please specify MSRV policy #122

Closed
newpavlov opened this issue Aug 25, 2019 · 2 comments · Fixed by #123
Closed

Please specify MSRV policy #122

newpavlov opened this issue Aug 25, 2019 · 2 comments · Fixed by #123

Comments

@newpavlov
Copy link

The latest v1.11 release has broke Minimum Supported Rust Version (MSRV) CI tests for RustCrypto crates (e.g. see RustCrypto/MACs#20). I will not ask you to yank v1.11 and release v2.0 just because of that, but it would be nice if you'll specify in README how you handle MSRV bumps.
@paholg paholg mentioned this issue Aug 26, 2019
Merged
@paholg
Copy link
Owner

paholg commented Aug 26, 2019

Woops. I'm sorry. I have removed the nested import braces in 1.11.1 and added Rust 1.22.0 as the MSRV (and added a build on it to Travis).

It should mostly work on as low a version as Rust 1.20.0, but not all tests pass there, so I am not comfortable using it as the MSRV. Since you were using 1.21.0, please let me know if that's a problem.

Otherwise, typenum should continue to work on old Rust versions and this should not happen again.

@newpavlov
Copy link
Author

Thank you! CI tests for hash functions on Rust 1.21 pass without issues.

tarcieri added a commit to RustCrypto/MACs that referenced this issue Aug 26, 2019
@tarcieri
Revert ".travis.yml: Stop testing 'hmac' on 1.21"
9e803da 
This reverts commit c75be69.

Fixed upstream:

paholg/typenum#122
@tarcieri tarcieri mentioned this issue Aug 26, 2019
Merged
@paholg paholg mentioned this issue Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build on Rust 1.22.0 paholg/typenum
2 participants
@newpavlov @paholg