Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with mingw #956

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Fix build with mingw #956

merged 1 commit into from
Dec 31, 2019

Conversation

jrb0001
Copy link
Contributor

@jrb0001 jrb0001 commented Dec 30, 2019

This fixes #953 (regression of #951). I tested with x86_64-pc-windows-msvc (VS2019) and x86_64-pc-windows-gnu and both seem to work now. It should also work with VS2017 but I can't test it.

@jrb0001 jrb0001 mentioned this pull request Dec 30, 2019
@Cobrand
Copy link
Member

Cobrand commented Dec 31, 2019

Thanks!

@Cobrand Cobrand merged commit 22fd302 into Rust-SDL2:master Dec 31, 2019
sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#951 broke building for x86_64-pc-windows-gnu and i686-pc-windows-gnu
2 participants