#947 broke building on x86_64-pc-windows-msvc/i686-pc-windows-msvc with VS2019

[jrb0001]

[sdl2-sys 0.32.6] SDL_string.obj : error LNK2019: Verweis auf nicht aufgel�stes externes Symbol "memset" in Funktion "SDL_vsnprintf_REAL". [...\target\x86_64-pc-windows-msvc\debug\build\sdl2-sys-48b20b00f4980a00\out\build\SDL2.vcxproj]
[sdl2-sys 0.32.6] ...\target\x86_64-pc-windows-msvc\debug\build\sdl2-sys-48b20b00f4980a00\out\build\Release\SDL2.dll : fatal error LNK1120: 1 nicht aufgel�ste Externe [...\target\x86_64-pc-windows-msvc\debug\build\sdl2-sys-48b20b00f4980a00\out\build\SDL2.vcxproj]

[Cobrand]

What did it break exactly? What's the error message?

[jrb0001]

Oops, I can't believe I forgot to include the error message. Anyways, it is the same error that #951 fixed (and #956 fixed the regression introduced by that). See also my comment in #947.

[Cobrand]

It is the same error that #951 fixed... so it is fixed by #956 and fine now or is this still happening on the latest version of master?

[jrb0001]

Yeah, it was fixed by both #951 and I verified it to work before submitting #956. But those patches are not applied anymore after merging #947 because the SDL2 version number is different and the patching code checks for that.

[Cobrand]

I see, so if the patch is still up to date, we just have to rename the 2.0.9 in the filename to 2.0.10, otherwise we should update it if there are conflicts, or remove it if it's not necessary anymore.

[rlabrecque]

Sorry for the spam!

I thought it was going to be that easy, but it required creating the diff with the 2.0.10 version of the file being patched.

MinGW was probably also broken before #960 .

[jrb0001]

@rlabrecque MinGW was broken by #951 and fixed by #956. #947 broke VS2019 but I think MinGW still worked and now you fixed everything again with #960.