Move ffi into sys, update bindgen, build.rs and update to sdl2.0.8 #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #744 Defines were not set correctly as target matching was wrong. Removed hide_type deprecated binding builder method use, in favor of blacklist_type. Added rustified_enum call, since newer bindgen versions will make constants instead of enums breaking the sdl2-sys crate. Bindings were regenerated using the following command: cargo build --features bindgen
The 'mixer' feature is re-exported so compiling without it will leave out the mixer function definitions in sdl2-sys crate as well. Progresses on #647
Progresses on #647
Progresses on #647
Progresses on #647
I'm not sure if this is the intended way of using bindgen, but the SDL_image bindings now piggy-back on the core SDL bindings by blacklisting some types that gets dragged into the image module. The solution probably does not scale, but it might be preferable to have autoupdateable bindings rather than having to do it manually. Progresses on #647
Had to change some mutability of some raw pointers used, but the ttf demo seem to work. Progresses on #647
Renamed the binding files to be consistent. The build script could probably benefit from a good cleanup. Closes #647
It should now be what the old behaviour was. If either mac_framework or use_mac_framework feature is set then it will use kind=framework, if not then it will use normal library name link argument.
|
@bgourlie It should be fine, but would you mind testing master now that it's been merged? This branch should solve all your issues. Thanks! |
|
I’ll try to test it out sometime this week, I’m in the middle of a move so
things are pretty busy at the moment!
…On Sun, Jul 8, 2018 at 10:30 AM Cobrand ***@***.***> wrote:
@bgourlie <https://github.com/bgourlie> It should be fine, but would you
mind testing master now that it's been merged? This branch should solve all
your issues. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#782 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA80zBttvwMf_pbxOFM-Socun3f7wx2xks5uEiWXgaJpZM4VGwTN>
.
|
|
I just tested the HEAD revision on master and everything appears to be working fine for my particular application. |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Move ffi into sys, update bindgen, build.rs and update to sdl2.0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #765 (already merged with this branch).
Closes #777 (fix)