Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl::mixer::sys is not public #738

Closed
PeterShinners opened this issue Dec 18, 2017 · 2 comments
Closed

sdl::mixer::sys is not public #738

PeterShinners opened this issue Dec 18, 2017 · 2 comments

Comments

@PeterShinners
Copy link

I can access sdl::sys but not sdl::mixer::sys from my own code. This seems useful as I am trying to access functions not exposed by the sdl2 bindings.

In the base sdl library it is defined as pub extern crate sdl2_sys as sys;. In the mixer module it is declared as use sys;. It feels like this is a simple oversight that is a non-controversial change.

I am still early days learning Rust. I may likely be doing something incorrect, or requesting something inappropriate.

@Cobrand
Copy link
Member

Cobrand commented Dec 25, 2017

No you are totally right, it should be fixed. sdl2_mixer was another crate at first (and was merged into this one later on), but at that time its ::sys was not public, and making the sys public was not part of the initial merge plan. This is related to issue #647, which has for roots closed issue #564.

@Cobrand
Copy link
Member

Cobrand commented Jul 11, 2018

Closed by #782

@Cobrand Cobrand closed this as completed Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants