Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WindowEvent::is_same_kind_as #1005

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

GuillaumeGomez
Copy link
Contributor

Following #1004.

@Cobrand Cobrand merged commit 65c3f6d into Rust-SDL2:master Jun 3, 2020
@GuillaumeGomez GuillaumeGomez deleted the w-event branch June 3, 2020 11:54
@GuillaumeGomez
Copy link
Contributor Author

Do you know when you'll make a new release btw? (You should also maybe "fix" the deprecated items you have, no? If you want I can do it.)

@Cobrand
Copy link
Member

Cobrand commented Jun 3, 2020

You should also maybe "fix" the deprecated items you have, no? If you want I can do it.

What do you mean by that?

I make new releases when I feel like there is a demand for it, or if people ask. I can make one during the week if you'd like.

@GuillaumeGomez
Copy link
Contributor Author

You have a few functions with a deprecated attribute. I think it's worth fixing them? For example, you have a method that became public whereas it shouldn't have. We can just remove the pub and the attribute and it's done. :)

As for the release, in the week would be great, thanks!

@Cobrand
Copy link
Member

Cobrand commented Jun 3, 2020

Oh for the deprecated attributes, we're just waiting on a few releases to remove them, but I haven't checked most of them in a while, so they're probably all good to remove? Let's say all the deprecated stuff that came in 0.32 or before is fine to remove.

@GuillaumeGomez
Copy link
Contributor Author

Ok! I'll send a PR shortly then.

sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants