Add helper functions for Event #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a pretty interesting function. I don't mind merging it, but just out of curiosity do you have a real world use-case for such a function? I have written many SDL2-based applications and I don't remember needing such a function 🤔 EDIT: talking about |
|
In case I'm in a menu, I want to be able to filter before calling a function. For now I have the function written in my code but having it upstream would be very convenient. :) |
|
Oh, I'll still need to have some more checks in case of buttons but that's already that less to check. |
|
I think I get your use-case, thanks for the PR! |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Add helper functions for Event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to write those helpers into my code so I think it's worth adding them upstream because I'm pretty sure I'm not the only one having some usage for them. :)