Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Mixed visibility for poll responses #5

Merged
merged 6 commits into from
Aug 6, 2021
Merged

[NEW] Mixed visibility for poll responses #5

merged 6 commits into from
Aug 6, 2021

Conversation

RonLek
Copy link
Collaborator

@RonLek RonLek commented Jun 25, 2021 •
edited
Loading

  • IPoll interface's confidential?: boolean property updated to visibility?: string.
  • Added anonymousOptions: Array<string> property to IPoll interface.
  • Mixed Visibility modal with MultiStaticSelectElement pops open when poll creator chooses "Mixed Visibility vote".
  • Makes mixed visibility stay consistent on finishing poll and when users cast votes.
  • Allows mixed visibility polls to be created within threads.
  • Shows anonymous marked responses as voted by "Anonymous" user.
Screencast.from.26-06-21.02.39.02.PM.IST.mp4

Closes #4

@RonLek RonLek requested a review from ramkumarkb June 26, 2021 09:15
@RonLek
Copy link
Collaborator Author

RonLek commented Jun 26, 2021

@murtaza98 @ramkumarkb please take a look. Thanks.

@RonLek
Copy link
Collaborator Author

RonLek commented Jul 2, 2021

@murtaza98 could you please take a look at this one as well. Thanks.

murtaza98
murtaza98 reviewed Jul 20, 2021
View reviewed changes
src/definition.ts Outdated Show resolved Hide resolved
murtaza98
murtaza98 reviewed Jul 20, 2021
View reviewed changes
PollApp.ts Outdated Show resolved Hide resolved
murtaza98
murtaza98 reviewed Jul 20, 2021
View reviewed changes
PollApp.ts Outdated Show resolved Hide resolved
murtaza98
murtaza98 reviewed Jul 20, 2021
View reviewed changes
PollApp.ts Outdated Show resolved Hide resolved
murtaza98
murtaza98 reviewed Jul 20, 2021
View reviewed changes
PollApp.ts Show resolved Hide resolved
@murtaza98 murtaza98 mentioned this pull request Jul 20, 2021
Merged
@RonLek RonLek force-pushed the mixed-visibility branch 2 times, most recently from 3d173ab to fce018f Compare July 24, 2021 09:01
@ramkumarkb ramkumarkb merged commit c4360c2 into RocketChat:master Aug 6, 2021
@murtaza98 murtaza98 mentioned this pull request Aug 22, 2021
Merged
@RonLek RonLek mentioned this pull request Sep 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murtaza98 murtaza98 murtaza98 approved these changes

@ramkumarkb ramkumarkb Awaiting requested review from ramkumarkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Mixed Visibility for Poll Responses
3 participants
@RonLek @murtaza98 @ramkumarkb