Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add user defined options #8

Merged
merged 5 commits into from
Aug 8, 2021

Conversation

RonLek
Copy link
Collaborator

@RonLek RonLek commented Jul 9, 2021

  • Added allowAddingOptions property to IPoll interface.
  • Provided StaticSelectElement within configuration to allow/disallow adding options by users after Poll creation.
  • "Add option" button shown only when adding options allowed and poll not finished.
  • Updated previously posted Poll message with newly added option (quanitity: 0, voters: []) when option submitted.
Screencast.from.09-07-21.12.55.37.PM.IST.mp4

Closes #7

@RonLek RonLek requested a review from ramkumarkb July 9, 2021 07:36
@RonLek
Copy link
Collaborator Author

RonLek commented Jul 9, 2021

@murtaza98 @ramkumarkb please take a look. Thanks.

PollApp.ts Outdated Show resolved Hide resolved
PollApp.ts Outdated Show resolved Hide resolved
@ramkumarkb ramkumarkb merged commit 72ad9c5 into RocketChat:master Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow adding user-defined choices after Poll creation
3 participants