[NEW] Allow configuration of SAML logout behavior #9524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/rocketchat-google-natural-language/.npm/package/npm-shrinkwrap.json # packages/rocketchat-ui-sidenav/client/createCombinedFlex.html # packages/rocketchat-ui-sidenav/client/createCombinedFlex.js
Merging current Rocket.Chat 0.55.1
- Removed unnecessary code for setting a custom tracking url - Make the list of domains editable - Changed comment
#15 - Add advanced configuration options for piwik analytics.
- Fixed formatting issues according to stylelint
#20 The CSS format for showing the knowledge base is broken.
An expert channel which was configured as private channel prevented startup
Making release for beta test.
…o release/0.55.1-0.2 Merging hotfix from master into release branch.
- add new labels
Hotfix/left hand panel
Hotfix bundle/0.56.0 0.2.2
* Deactivate Request Closing Comments * Deactivate closing comment for Live-Chat * Create the swal config more nicely * text translation and mergin object properties * incl. setting to config role and roll back to using _ for object mergin * minor naming adjustments
Adds: - encodeURI in AmazonS3 store to allow special chars in file name;
Use encodeURI in AmazonS3 contentDisposition file.name to prevent fail
mrsimpson
force-pushed
the
core/#9522-saml-logout
branch
from
0433608
to
7de5e68
Compare
|
henrikscholl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
damn it - pushed -f to the wrong branch - will create a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
This PR addresses a TODO in the current implementation of the SAML logout handling. It allows the admin to configure what should happen once a user logged-in via SAML logs out: whether the SAML session or only the Rocket.Chat-session be terminated.
Closes #9522
Decided to make it configurable not with a boolean value, but with a select.
This allows for more flexibility handling the logout, e. g. asking the user what he'd like to log-off from.