Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't kill SAML-session on logout #9522

Closed
mrsimpson opened this issue Jan 26, 2018 · 0 comments
Closed

Don't kill SAML-session on logout #9522

mrsimpson opened this issue Jan 26, 2018 · 0 comments
Assignees
Milestone

Comments

@mrsimpson
Copy link
Collaborator

Description:

When using SAML-session, ligging out should end the session of the chat, but not (necessarily) the SAML session. Other applications shall still be able to use the session.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.59.3

Steps to Reproduce:

1.Configure a SAML provider
2. Log.in using SAML to another application
3. Log-in using SAML to Rocket.Chat
4. Log-out from Rocket.Chat
5. Open the other application again

Expected behavior:

Other applications using the same SAML-session should still be authenticated

Actual behavior:

The SAML-session is killed

Proposal

Allow the admin to configure per SAML-provider how the logout using the provider shall behave:

  • end the SAML session (default for compatibility)
  • only end the RC-session
mrsimpson added a commit to assistify/Rocket.Chat that referenced this issue Jan 27, 2018
mrsimpson added a commit to assistify/Rocket.Chat that referenced this issue Jan 28, 2018
@engelgabriel engelgabriel added this to the 0.62.0 milestone Jan 30, 2018
rodrigok added a commit that referenced this issue Feb 19, 2018
[NEW] Allow configuration of SAML logout behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants