Add read only channels (completed) #4034

garychapman · 2016-08-17T06:57:17Z

@RocketChat/core

Closes #825 #3861 #3641 #3539
Related #2043

I've taken the great work already done by @alexbrazier and extended it to completion:

Added Read Only controls to the Room Info admin panel
MessageBox and all other input methods (including drag/drop) are disabled for muted users in the room
Users already in a room are muted when it becomes read-only

Thanks also to @timkinnane for his invaluable assistance

# Conflicts: # packages/rocketchat-channel-settings/client/views/channelSettings.coffee # packages/rocketchat-lib/i18n/en.i18n.json

- Any users present when a read-only channel is created are muted - Refactored to remove unnecessary addUsernameByIdAndMute method - Standardised channel info icon

- Completed setReadOnlyById to set/unset muted user array

- messageBox hidden and dropzone disabled for read-only room if user doesn't have permission to post - renamed users-typing class to stream-info, added 'this room is read only' message - setReadOnlyById now removes empty muted array from room record

# Conflicts: # packages/rocketchat-ui-flextab/flex-tab/tabs/membersList.coffee # packages/rocketchat-ui-message/message/messageBox.html

rodrigok · 2016-08-18T02:00:51Z

Wow, this is huge and awesome 😄

@garychapman I will try to review your PR ASAP

graywolf336 · 2016-08-18T03:40:03Z

packages/rocketchat-ui-admin/admin/rooms/adminRooms.coffee

@@ -48,7 +48,7 @@ Template.adminRooms.onCreated ->
 		groups: ['adminrooms'],
 		id: 'admin-room',
 		i18nTitle: 'Room_Info',
-		icon: 'icon-info',
+		icon: 'icon-info-circled',


Curious why this changed? I haven't seen the change with this, just curious

Just for consistency with the default channelSettings icon.

alexbrazier · 2016-08-19T23:24:43Z

@garychapman Thanks for finishing this off! I've been quite busy and didn't find the time.

alexbrazier · 2016-08-19T23:54:20Z

packages/rocketchat-channel-settings/server/models/Rooms.coffee

+		users.usernames.forEach (userName) ->
+
+			# lookup the user
+			user = RocketChat.models.Users.findOneByUsername userName


This seems quite expensive everytime. Can you just request the required fields e.g. {fields: {user._id: 1}}?

Alternatively it might be more efficient to request all the user ids at once e.g.

usernames = @findOne(query, { fields: { usernames: 1 }}) users = RocketChat.models.Users.findUsersByUsernames usernames, {fields: {username: 1}} users.forEach (user) -> #Use user._id and user.username

Good catch. I've updated the code.

# Conflicts: # packages/rocketchat-authorization/server/startup.coffee

…/strata.chat into feature/read-only-rooms

Lucky21110 · 2016-08-25T23:52:32Z

Hello,

When it will be committed into develop ?

Lucky21110 · 2016-08-28T20:44:12Z

Hello,

How I can edit this on my current release and put it in prod ?
I downloaded all file using git but it looks like different.

When this will be put in prod ?

Long time ago that I'm waiting for that

geekgonecrazy · 2016-08-28T21:30:33Z

@Lucky21110 I believe we talked on Rocket.Chat. Here

rodrigok · 2016-09-03T17:57:02Z

@garychapman Can you fix the conflicts please?

# Conflicts: # packages/rocketchat-channel-settings/client/views/channelSettings.coffee # packages/rocketchat-channel-settings/client/views/channelSettings.html # packages/rocketchat-channel-settings/server/methods/saveRoomSettings.coffee # packages/rocketchat-lib/server/methods/addUserToRoom.coffee # packages/rocketchat-ui/views/app/room.coffee # server/methods/createChannel.coffee # server/methods/createPrivateGroup.coffee # server/methods/joinRoom.coffee # server/startup/roomPublishes.coffee

garychapman · 2016-09-05T09:29:28Z

@rodrigok Done!

# Conflicts: # packages/rocketchat-lib/server/methods/createChannel.coffee

garychapman · 2016-09-06T05:33:00Z

@RocketChat/core could someone please lgtm and merge this? I've already done a couple of time-consuming conflict fixes over the past few weeks...

geekgonecrazy · 2016-09-06T05:39:39Z

LGTM @RocketChat/Core ?

marceloschmidt · 2016-09-06T12:08:01Z

It's incomplete. The set-readonly permission is never created.
I'll commit and merge in a bit.

marceloschmidt · 2016-09-06T12:44:35Z

Merged in 9866b80. Thank you @garychapman and @alexbrazier

infinitnet · 2016-10-28T09:43:19Z

I have one objection about how this has been implemented: Currently any admin user can still send messages in "read only" channels. It would be much better if only the channel owner(s) would be allowed to do that and not every admin just because he/she has admin permissions. In our team we have more admin users than non-admin users, which makes the currently implementation of read-only pretty much useless, because every admin can still speak and there is no way to mute them on a per channel basis..

infinitnet · 2016-10-28T09:51:59Z

By the way what I mentioned above wouldn't be an issue if disabling post-readonly for admins would work, but it doesn't seem to change anything even after restarting rocket.chat. Admins can still post to read-only channels.

marceloschmidt · 2016-10-28T10:52:58Z

@infinitnet you're right. There's a bug with our post-readonly permission. When a room is set to readonly, we mute users without post-readonly permission, instead of checking it when the user tries to send a message. So, for a quick dirty solution, after you remove their post-readonly permission, unset then reset the room as readonly. I'll make sure we have another issue for this bug.

timkinnane · 2016-10-28T11:26:29Z

Those are awesome suggestions @infinitnet. Thanks for the detective work @marceloschmidt.

geekgonecrazy · 2016-10-28T14:22:41Z

@infinitnet Might consider creating another role instead of making them all admin. With them all admin, all they have to do is go and add that permission back and they would be able to speak. If you're wanting to restrict your admin's it would probably be a good idea to give them their own role with the reduced permissions.

Like existing admin role being super admin. Then the new role just basic admins. Just a thought.

infinitnet · 2016-10-28T14:37:19Z

@geekgonecrazy I'm aware that admins could just add the permission to speak in a read-only channel. I don't mean to keep them from doing that. I only want to restrict everyone's ability to speak in a read-only channel to prevent unintentional messages in a channel that gets its content from other sources than user messages (RSS feeds, bots, webhooks, etc.). Moving everyone to a new group seems like a lot of work to accomplish what I need: the ability to remove post-readonly permission from any group, including admin. A feature to manually mute users only in a certain channel would do too (for example toggle "Mute" for each user in "Members List" of a channel).

alexbrazier and others added 13 commits July 25, 2016 22:18

Add read only channels

97e8be8

Mute users added by room owner in read only room

da84417

Add post read only permission

072e472

Add setting to disable system notifications

3161216

Add missing strings

9638544

Merge branch 'develop' into feature/read-only-rooms

b3ab22e

# Conflicts: # packages/rocketchat-channel-settings/client/views/channelSettings.coffee # packages/rocketchat-lib/i18n/en.i18n.json

- Fixed merge issues

5b680c5

- Any users present when a read-only channel is created are muted - Refactored to remove unnecessary addUsernameByIdAndMute method - Standardised channel info icon

- Refactored to remove unnecessary addUsernameByIdAndMute method

f852091

- Completed setReadOnlyById to set/unset muted user array

- Added ReadOnly to admin channel settings panel

4975ed2

Merge branch 'develop' into feature/read-only-rooms

100359e

# Conflicts: # packages/rocketchat-ui-flextab/flex-tab/tabs/membersList.coffee # packages/rocketchat-ui-message/message/messageBox.html

Merge branch 'develop' into feature/read-only-rooms

83347de

Merge branch 'develop' into feature/read-only-rooms

b485a91

graywolf336 reviewed Aug 18, 2016
View reviewed changes

alexbrazier reviewed Aug 19, 2016
View reviewed changes

garychapman added 4 commits August 22, 2016 13:54

Merge branch 'develop' into feature/read-only-rooms

e277b8e

# Conflicts: # packages/rocketchat-authorization/server/startup.coffee

Optimised username lookup when muting existing users

763436f

Merge branch 'feature/read-only-rooms' of https://github.com/4thParty…

909d333

…/strata.chat into feature/read-only-rooms

Merge branch 'develop' into feature/read-only-rooms

37efedd

engelgabriel assigned rodrigok Aug 31, 2016

garychapman added 2 commits September 5, 2016 18:51

Keeping Travis happy

48249aa

Merge branch 'rdevelop' into feature/read-only-rooms

b7d4587

# Conflicts: # packages/rocketchat-lib/server/methods/createChannel.coffee

Merge branch 'develop' into feature/read-only-rooms

885ee7a

alexbrazier mentioned this pull request Sep 6, 2016

Add read only channels #3861

Closed

2 tasks

marceloschmidt closed this Sep 6, 2016

marceloschmidt mentioned this pull request Oct 28, 2016

readonly and post-readonly permission not working properly #4769

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add read only channels (completed) #4034

Add read only channels (completed) #4034

garychapman commented Aug 17, 2016

rodrigok commented Aug 18, 2016

graywolf336 Aug 18, 2016

garychapman Aug 18, 2016

alexbrazier commented Aug 19, 2016

alexbrazier Aug 19, 2016

garychapman Aug 22, 2016

Lucky21110 commented Aug 25, 2016

Lucky21110 commented Aug 28, 2016

geekgonecrazy commented Aug 28, 2016

rodrigok commented Sep 3, 2016

garychapman commented Sep 5, 2016

garychapman commented Sep 6, 2016

geekgonecrazy commented Sep 6, 2016

marceloschmidt commented Sep 6, 2016

marceloschmidt commented Sep 6, 2016

infinitnet commented Oct 28, 2016

infinitnet commented Oct 28, 2016

marceloschmidt commented Oct 28, 2016

timkinnane commented Oct 28, 2016

geekgonecrazy commented Oct 28, 2016

infinitnet commented Oct 28, 2016

Add read only channels (completed) #4034

Add read only channels (completed) #4034

Conversation

garychapman commented Aug 17, 2016

rodrigok commented Aug 18, 2016

graywolf336 Aug 18, 2016

Choose a reason for hiding this comment

garychapman Aug 18, 2016

Choose a reason for hiding this comment

alexbrazier commented Aug 19, 2016

alexbrazier Aug 19, 2016

Choose a reason for hiding this comment

garychapman Aug 22, 2016

Choose a reason for hiding this comment

Lucky21110 commented Aug 25, 2016

Lucky21110 commented Aug 28, 2016

geekgonecrazy commented Aug 28, 2016

rodrigok commented Sep 3, 2016

garychapman commented Sep 5, 2016

garychapman commented Sep 6, 2016

geekgonecrazy commented Sep 6, 2016

marceloschmidt commented Sep 6, 2016

marceloschmidt commented Sep 6, 2016

infinitnet commented Oct 28, 2016

infinitnet commented Oct 28, 2016

marceloschmidt commented Oct 28, 2016

timkinnane commented Oct 28, 2016

geekgonecrazy commented Oct 28, 2016

infinitnet commented Oct 28, 2016