Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readonly and post-readonly permission not working properly #4769

Closed
marceloschmidt opened this issue Oct 28, 2016 · 7 comments · Fixed by #11311
Closed

readonly and post-readonly permission not working properly #4769

marceloschmidt opened this issue Oct 28, 2016 · 7 comments · Fixed by #11311

Comments

@marceloschmidt
Copy link
Member

Your Rocket.Chat version: 0.45.0-develop

The post-readonly permission is not checked when the user tries to send a message, but only when the room is set to readonly.

re: #4034 (comment)

@infinitnet
Copy link

infinitnet commented Oct 28, 2016

@marceloschmidt (in reply to #4034 (comment)): Thanks for looking into this so quickly. After removing post-readonly from admin group I actually did try setting read-only to false and then true again (of course clicking "Save" after each change), but that didn't do the trick either. I just did it again just to be sure and admins still aren't being muted. I'm using the 0.44 release by the way.

@timkinnane
Copy link
Contributor

I remember discussing this with the original contributor. I think it was by design to reduce overhead by not checking the permission on every post. Probably just needs a few lines shifted, I'll look into a fix.

@cyclops24
Copy link
Contributor

Part of #8494

@engelgabriel
Copy link
Member

assistify#70

@engelgabriel
Copy link
Member

Duplicates:
#8388
#7356
#6302

@mnlbox
Copy link

mnlbox commented Sep 13, 2018

Any news guys?

@Hudell
Copy link
Contributor

Hudell commented Sep 13, 2018

The #11311 PR is handling this issue. It still needs some tweaks, but I'll try to have it ready for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment