Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable requiring email for bots #3825

Closed
wants to merge 4 commits into from

Conversation

timkinnane
Copy link
Contributor

@RocketChat/core

Closes #3818, related to #3679

See issue notes for more details.

Tim Kinnane added 2 commits July 21, 2016 16:38
- Disable requiring email when creating bot users from flex tab
- When bot selected disables verification, change password and welcome email fields
'change #role': (e) ->
isBot = $(e.target).val() is 'bot'
$ '#verified'
.prop 'disabled', isBot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 2 space before .prop instead of a tab =)

@sampaiodiego
Copy link
Member

hi @timkinnane .. thanks for the fix =)

I tried this out and I didn't like the behaviour you introduced: every time I choose a role other than bot it is checking the fields: verified, require password change and send welcome email.

what you think just disabling them when the bot role is selected and just enabling them otherwise?

@timkinnane
Copy link
Contributor Author

Yeah, you're right @sampaiodiego - I kinda did that in a hurry, thought that it wasn't ideal but didn't have time to follow up. The reason I changed the checks is because there's no clear visual state for disabled inputs. From user's perspective they can't tell if the field is disabled or if clicks just stopped working. I guess the responsible thing to do is close this now and resubmit when I've had time to work some UI updates for disabled fields so I don't have to change selections.

@timkinnane timkinnane closed this Jul 24, 2016
@sampaiodiego
Copy link
Member

ok @timkinnane .. thanks again, looking forward for your new changes..

@timkinnane timkinnane deleted the no-email-bots branch August 24, 2016 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants