Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent invalid role assignment / selection #3679

Closed
timkinnane opened this issue Jul 4, 2016 · 1 comment
Closed

Prevent invalid role assignment / selection #3679

timkinnane opened this issue Jul 4, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@timkinnane
Copy link
Contributor

0.35.0

When creating a user, role select allows you to chose any role, regardless the scope. If you can chose Moderator or Owner which are room scoped roles, they don't get a base role of User and can't access any functionality, even to navigate to a room.

This role select helper needs to filter the role selection to only roles with global scope.
It should also only include Admin in the list if the current user can assign-admin-role.

We also have made changes to resolve #3656 (with help from Ethaan). He pointed out that there's no protection against changing the role of the last admin. All areas where admin can be un-assigned should invoke a helper to check you're not removing the last one - includes Permissions edit view, Remove Admin buttons, user role select from User Edit fly out.

@timkinnane timkinnane changed the title Prevent from invalid role assignment / selection Prevent invalid role assignment / selection Jul 4, 2016
@ggazzo ggazzo added this to the 0.75.0 milestone Feb 8, 2019
@engelgabriel engelgabriel modified the milestones: 1.0.0, 1.1.0 Apr 6, 2019
@engelgabriel engelgabriel modified the milestones: 1.1.0, 1.3.0 Jul 10, 2019
@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@engelgabriel engelgabriel modified the milestones: 2.0.0, 2.2.0 Oct 13, 2019
@ggazzo
Copy link
Member

ggazzo commented Nov 4, 2019

fixed long time ago, any problem let me know

@ggazzo ggazzo closed this as completed Nov 4, 2019
@tassoevan tassoevan added stat: triaged Issue reviewed and properly tagged and removed Triaged labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants