Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app subprocess restart not running onEnable lifecycle #34175

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

d-gubert
Copy link
Member

Backport #34172

Copy link
Contributor

dionisio-bot bot commented Dec 13, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.9, but it targets 6.10.8

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.10.9@52e39e1). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-6.10.9   #34175   +/-   ##
=================================================
  Coverage                  ?   56.59%           
=================================================
  Files                     ?     2504           
  Lines                     ?    55706           
  Branches                  ?    11529           
=================================================
  Hits                      ?    31527           
  Misses                    ?    21481           
  Partials                  ?     2698           
Flag Coverage Δ
e2e 56.45% <ø> (?)
unit 71.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review December 13, 2024 22:38
@d-gubert d-gubert requested review from a team as code owners December 13, 2024 22:38
@sampaiodiego sampaiodiego added this to the 6.10.9 milestone Dec 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 16, 2024
@kodiakhq kodiakhq bot merged commit e01281b into release-6.10.9 Dec 16, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/deno-restart-process branch December 16, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants