Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app subprocess restart not running onEnable lifecycle #34172

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Dec 12, 2024

Proposed changes (including videos or screenshots)

  • Run onEnable on the subprocess restart if the app is enabled
  • Ensure disabled status is persisted if an error occurs during app init

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 63c7241

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/apps-engine Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (f11efb4) to head (63c7241).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34172   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34172/
on branch gh-pages at 2024-12-12 19:55 UTC

@sampaiodiego sampaiodiego marked this pull request as ready for review December 12, 2024 21:13
@sampaiodiego sampaiodiego requested a review from a team as a code owner December 12, 2024 21:13
@sampaiodiego sampaiodiego merged commit eb794b7 into develop Dec 12, 2024
48 checks passed
@sampaiodiego sampaiodiego deleted the fix/deno-restart-process branch December 12, 2024 21:14
@sampaiodiego
Copy link
Member

/backport 7.0.2

1 similar comment
@sampaiodiego
Copy link
Member

/backport 7.0.2

@sampaiodiego
Copy link
Member

/bark

1 similar comment
@sampaiodiego
Copy link
Member

/bark

Copy link
Contributor

dionisio-bot bot commented Dec 12, 2024

AU AU

@sampaiodiego
Copy link
Member

/backport 7.0.2

Copy link
Contributor

dionisio-bot bot commented Dec 12, 2024

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.0.2-34172
git cherry-pick eb794b7fd6bf3ff5a37a38bccaba247ed36db744
// solve the conflict
git push

after that just run /backport 7.0.2 again

@sampaiodiego
Copy link
Member

/backport 7.0.2

Copy link
Contributor

dionisio-bot bot commented Dec 12, 2024

Pull request #34173 added to Project: "Patch 7.0.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants