Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newly created teams displayed as channels in sidebar with DISABLE_DB_WATCHERS enabled #33908

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Nov 7, 2024

Proposed changes

This PR addresses the issue described in CORE-800 where newly created teams are mistakenly displayed as channels in the sidebar when the DISABLE_DB_WATCHERS environment variable is enabled.

Screen.Recording.2024-11-07.at.12.28.33.mov

Issue(s)

Steps to test or reproduce

  • Set DISABLE_DB_WATCHERS to true.
  • Create a new team – it will initially appear as a channel.
  • Refresh the page – the team should now display correctly as a team.

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 7, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: 92e50a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ricardogarim ricardogarim added this to the 7.1.0 milestone Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33908/
on branch gh-pages at 2024-11-07 17:05 UTC

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (87d0536) to head (92e50a3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33908   +/-   ##
========================================
  Coverage    75.20%   75.20%           
========================================
  Files          495      495           
  Lines        21595    21595           
  Branches      5362     5362           
========================================
  Hits         16240    16240           
  Misses        4713     4713           
  Partials       642      642           
Flag Coverage Δ
unit 75.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim marked this pull request as ready for review November 7, 2024 15:37
@ricardogarim ricardogarim requested a review from a team as a code owner November 7, 2024 15:37
@ricardogarim ricardogarim changed the title fix: add event notification on teams creation fix: newly created teams displayed as channels in sidebar with DISABLE_DB_WATCHERS enabled Nov 7, 2024
@ricardogarim ricardogarim added the stat: QA assured Means it has been tested and approved by a company insider label Nov 7, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 7, 2024
@kodiakhq kodiakhq bot merged commit 1eca1fb into develop Nov 7, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the fix/create-team-notification branch November 7, 2024 18:38
KevLehman pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants