Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newly created teams displayed as channels in sidebar with DISABLE_DB_WATCHERS enabled #33908

Merged
merged 5 commits into from
Nov 7, 2024
Merged

fix: newly created teams displayed as channels in sidebar with DISABLE_DB_WATCHERS enabled #33908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0ebb86
fix: add event notification on teams creation
ricardogarim Nov 7, 2024
d4aa059
changeset
ricardogarim Nov 7, 2024
7236c12
Merge branch 'develop' into fix/create-team-notification
ricardogarim Nov 7, 2024
403af35
Merge branch 'develop' into fix/create-team-notification
kodiakhq[bot] Nov 7, 2024
92e50a3
Merge branch 'develop' into fix/create-team-notification
kodiakhq[bot] Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/light-terms-ring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes the issue where newly created teams are incorrectly displayed as channels on the sidebar when the DISABLE_DB_WATCHERS environment variable is enabled
4 changes: 3 additions & 1 deletion apps/meteor/server/services/team/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { addUserToRoom } from '../../../app/lib/server/functions/addUserToRoom';
import { checkUsernameAvailability } from '../../../app/lib/server/functions/checkUsernameAvailability';
import { getSubscribedRoomsForUserWithDetails } from '../../../app/lib/server/functions/getRoomsWithSingleOwner';
import { removeUserFromRoom } from '../../../app/lib/server/functions/removeUserFromRoom';
import { notifyOnSubscriptionChangedByRoomIdAndUserId } from '../../../app/lib/server/lib/notifyListener';
import { notifyOnSubscriptionChangedByRoomIdAndUserId, notifyOnRoomChangedById } from '../../../app/lib/server/lib/notifyListener';
import { settings } from '../../../app/settings/server';

export class TeamService extends ServiceClassInternal implements ITeamService {
Expand Down Expand Up @@ -131,6 +131,8 @@ export class TeamService extends ServiceClassInternal implements ITeamService {
await Message.saveSystemMessage('user-converted-to-team', roomId, team.name, createdBy);
}

void notifyOnRoomChangedById(roomId, 'inserted');

return {
_id: teamId,
...teamData,
Expand Down
Loading