Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: DiscussionsList title missing style #32103

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 1, 2024

Proposed changes (including videos or screenshots)

Introduced here: #31978
Due to some changes in the semantics of Contextualbar the discussion list wasn't using the proper component so it lost the style.
Adding the proper component for the title fixes the issue!

Issue(s)

Steps to test or reproduce

Further comments

CORE-226

Copy link

changeset-bot bot commented Apr 1, 2024

🦋 Changeset detected

Latest commit: ee1b037

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 6.7 milestone Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 21.27660% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 52.97%. Comparing base (d951e63) to head (867ab1f).

❗ Current head 867ab1f differs from pull request most recent head ee1b037. Consider uploading reports for the commit ee1b037 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.7.0   #32103      +/-   ##
=================================================
- Coverage          54.74%   52.97%   -1.78%     
=================================================
  Files               2299     2242      -57     
  Lines              50738    49475    -1263     
  Branches           10380    10041     -339     
=================================================
- Hits               27779    26209    -1570     
- Misses             20491    20881     +390     
+ Partials            2468     2385      -83     
Flag Coverage Δ
e2e 50.36% <33.33%> (-3.35%) ⬇️
e2e-api 40.08% <13.51%> (-0.08%) ⬇️
unit 75.80% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris changed the title regression: DiscussionsList missing style regression: DiscussionsList title missing style Apr 1, 2024
@dougfabris dougfabris force-pushed the reg/discussionsListTitle branch from 867ab1f to ee1b037 Compare April 1, 2024 16:31
@dougfabris dougfabris changed the base branch from develop to release-6.7.0 April 1, 2024 16:31
@dougfabris dougfabris marked this pull request as ready for review April 1, 2024 17:04
@dougfabris dougfabris requested a review from a team as a code owner April 1, 2024 17:04
Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 1, 2024
@kodiakhq kodiakhq bot merged commit fc9ce16 into release-6.7.0 Apr 1, 2024
9 checks passed
@kodiakhq kodiakhq bot deleted the reg/discussionsListTitle branch April 1, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants