Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Contextualbar as dialog instead of aside #31978

Merged
merged 10 commits into from
Mar 18, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 13, 2024

Proposed changes (including videos or screenshots)

  • Esc key should close the contextualbar

Issue(s)

Steps to test or reproduce

Further comments

SR-26

Copy link

changeset-bot bot commented Mar 13, 2024

⚠️ No Changeset found

Latest commit: c343dbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the title chore: Use Contextualbar as dialog instead of aside chore: Contextualbar as dialog instead of aside Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.62%. Comparing base (b7fa3b2) to head (c343dbf).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31978      +/-   ##
===========================================
+ Coverage    54.60%   54.62%   +0.02%     
===========================================
  Files         2293     2295       +2     
  Lines        50532    50575      +43     
  Branches     10319    10327       +8     
===========================================
+ Hits         27592    27627      +35     
- Misses       20441    20451      +10     
+ Partials      2499     2497       -2     
Flag Coverage Δ
e2e 53.69% <94.11%> (-0.01%) ⬇️
e2e-api 40.19% <ø> (+0.07%) ⬆️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the chore/contextualbarDialog branch from 7caf465 to 6045670 Compare March 16, 2024 14:58
@dougfabris dougfabris marked this pull request as ready for review March 18, 2024 13:33
@dougfabris dougfabris requested review from a team as code owners March 18, 2024 13:33
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 18, 2024
@kodiakhq kodiakhq bot merged commit 5ecfd6f into develop Mar 18, 2024
46 checks passed
@kodiakhq kodiakhq bot deleted the chore/contextualbarDialog branch March 18, 2024 17:46
@ggazzo ggazzo added this to the 6.7 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants