Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Livechat): More Livechat Tests #31995

Merged
merged 4 commits into from
Mar 21, 2024
Merged

test(Livechat): More Livechat Tests #31995

merged 4 commits into from
Mar 21, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Mar 14, 2024

Existing tests:

  • Basic operations on new chat with clearLocalStorageWhenChatEnded disabled
  • Basic operations on new chat with clearLocalStorageWhenChatEnded enabled (failing, needs regression: Livechat resubscription #31985 to pass)

New tests:

  • Change department from widget (before & after new chat)
  • Close chat from widget (before & after new chat)
  • Close chat and start as another visitor (clearLocalStorageWhenChatEnded` enabled) (failing, needs regression: Livechat resubscription #31985 to pass)

Copy link

changeset-bot bot commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: 4a97dd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.75%. Comparing base (5e1b782) to head (4a97dd9).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31995      +/-   ##
===========================================
+ Coverage    54.65%   54.75%   +0.10%     
===========================================
  Files         2298     2298              
  Lines        50638    50702      +64     
  Branches     10325    10352      +27     
===========================================
+ Hits         27677    27764      +87     
+ Misses       20470    20443      -27     
- Partials      2491     2495       +4     
Flag Coverage Δ
e2e 53.78% <ø> (+0.02%) ⬆️
e2e-api 40.14% <ø> (+0.06%) ⬆️
unit 75.74% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.7 milestone Mar 14, 2024
@MartinSchoeler MartinSchoeler force-pushed the moar-livechat-tests branch 3 times, most recently from d384cf3 to de1c6bf Compare March 20, 2024 12:58
@ggazzo ggazzo marked this pull request as ready for review March 21, 2024 17:57
@ggazzo ggazzo requested review from a team as code owners March 21, 2024 17:57
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 21, 2024
@ggazzo ggazzo merged commit c8b11da into develop Mar 21, 2024
43 of 44 checks passed
@ggazzo ggazzo deleted the moar-livechat-tests branch March 21, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants