-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: German translation switches 'conversation' and 'discussion' #31595
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31595 +/- ##
===========================================
- Coverage 54.39% 49.54% -4.86%
===========================================
Files 2276 3331 +1055
Lines 50105 81875 +31770
Branches 10227 16901 +6674
===========================================
+ Hits 27253 40561 +13308
- Misses 20369 36572 +16203
- Partials 2483 4742 +2259
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for providing a quick fix @hardikbhatia777!
I marked three occurences where we need to use the plural. Apart from these the changes look fine to me. Could you also please change the de-IN and de-AT translation files. They have the same inconsistencies. Appreciated!
3fb04e0
to
0e93dd5
Compare
Thanks for the help @david-uhlig! I've fixed de-IN as well. de-AT seems to not have a lot of the translations for some reason? I'm guessing it's outdated as of now and needs to be synced with the english i18n file. Anyways, the main de.i18n file should be good now :) If there's any other errors you can spot, do let me know and I'll have it changed right away. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! There seems to be a fallback to de.i18n.json for the missing de-AT.i18n.json lines, so this works out fine. Well done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work folks. Looks good to me.
Proposed changes (including videos or screenshots)
German translation files don't differentiate between 'Unterhaltung' (meaning entertainment / conversation) and 'Diskussion' (Discussion). This creates inconsistencies in labels and tool tips across the UI and should be streamlined.
I've replaced all appropriate occurances of the same to match the exact translation of English (and verified them using Google Translate).
If I replaced something that's inappropriate, please let me know :) I'll change it right away.
Issue(s)
Closes #31587
Steps to test or reproduce
Further comments