[NEW] Capability to search visitors by custom fields #26312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
requested changes
Jul 20, 2022
…o fix/custom-field-search2
KevLehman
requested changes
Jul 25, 2022
Co-authored-by: Kevin Aleman <[email protected]>
…o fix/custom-field-search2
…t/Rocket.Chat into fix/custom-field-search2
|
Edit: looking better, the first save (creation) doesn't include the "searchable" status, but it's included in next saves. That means "searchable" is not required (missing validation?) but it should (as a boolean would be true or false by default, so we'll have always a value) |
…idate searchable value on API
…t/Rocket.Chat into fix/custom-field-search2
…o fix/custom-field-search2
Oh man, i didn't change the creation page, only the edit page, fixed now. |
…o fix/custom-field-search2
…o fix/custom-field-search2
…o fix/custom-field-search2
…o fix/custom-field-search2
…o fix/custom-field-search2
aleksandernsilva
previously approved these changes
Aug 24, 2022
KevLehman
previously approved these changes
Aug 25, 2022
casalsgh
dismissed
sampaiodiego’s stale review
All approved. Just unblocking the PR
…et.Chat into fix/custom-field-search2
KevLehman
dismissed stale reviews from aleksandernsilva and themself
via
ae4ee00
aleksandernsilva
previously approved these changes
Aug 25, 2022
…et.Chat into fix/custom-field-search2
KevLehman
approved these changes
Aug 25, 2022
sampaiodiego
approved these changes
Aug 25, 2022
sampaiodiego
changed the title
gabriellsh
added a commit
that referenced
this pull request
Aug 26, 2022
…hreads * 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits) Chore: Upgrade dependencies (#26694) Chore: More Omnichannel tests (#26691) Regression: Banner - Room not found - Omnichannel room (#26693) [NEW] Capability to search visitors by custom fields (#26312) Chore: Create tests for Omnichannel admin add a custom fields (#26609) [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689) [IMPROVE] Added identification on calls to/from existing contacts (#26334) Regression: invalid statistics format (#26684) Regression: "Cache size is not a function" error when booting (#26683) [FIX] Correct IMAP configuration for email inbox (#25789) [FIX] Active users count on `@all` and `@here` (#25957) [FIX] Autotranslate method should respect setting (#26549) Chore: Remove italic/bold font-style from system messages (#26655) Chore: Convert AppSetting to tsx (#26625) Chore: Remove & Test old closeChat templates (#26631) [IMPROVE] General federation improvements (#26150) [NEW] Warn admins about running multiple instances of the monolith (#26667) Regression: Prevent message from being temp forever (#26668) Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) ...
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Diego Sampaio <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Users of the endpoints api/v1/omnichannel/contact.search and /api/v1/livechat/visitors.search are now able to search by custom fields in their objects.
Capability of selecting if a custom field can be searched for is added in the Omnichannel pannel as a toggle for
searchable, the included JSON in the Accounts' Custom Field example has been updated to make it explicit for future configurations that the field has to be enabled as searchable for that to happen.Issue(s)
Steps to test or reproduce
Create a new custom field on Omnichannel->custom field, selecting it as searchable.
Edit a LiveChat visitor conversation to include custom field created above.
On the contact center, you can now search for the contents of that custom field.
Further comments
I completely broke the other branch, so here it is again