[FIX] Correct IMAP configuration for email inbox #25789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arking new e-mails as read, this alternative tag, !SEEN, fixes this
KevLehman
requested changes
Jun 7, 2022
…o fix/imap-breaking-configuration-change
KevLehman
requested changes
Jun 16, 2022
murtaza98
reviewed
Jun 20, 2022
murtaza98
reviewed
Jun 21, 2022
murtaza98
suggested changes
Jun 21, 2022
There was a problem hiding this comment.
@cauefcr Can you also check the builds, please? It seems to be failing because of some recent changes
Also, I created this new PR on top of your PR to migrate the logger which was getting used on the email feature. Do you mind reviewing it?
Co-authored-by: Murtaza Patrawala <[email protected]>
…o fix/imap-breaking-configuration-change
….com/RocketChat/Rocket.Chat into fix/imap-breaking-configuration-change
….com/RocketChat/Rocket.Chat into fix/imap-breaking-configuration-change
KevLehman
requested changes
Aug 18, 2022
….com/RocketChat/Rocket.Chat into fix/imap-breaking-configuration-change
…o fix/imap-breaking-configuration-change
KevLehman
previously approved these changes
Aug 19, 2022
tassoevan
requested changes
Aug 19, 2022
KevLehman
approved these changes
Aug 22, 2022
tassoevan
approved these changes
Aug 25, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 26, 2022
…hreads * 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits) Chore: Upgrade dependencies (#26694) Chore: More Omnichannel tests (#26691) Regression: Banner - Room not found - Omnichannel room (#26693) [NEW] Capability to search visitors by custom fields (#26312) Chore: Create tests for Omnichannel admin add a custom fields (#26609) [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689) [IMPROVE] Added identification on calls to/from existing contacts (#26334) Regression: invalid statistics format (#26684) Regression: "Cache size is not a function" error when booting (#26683) [FIX] Correct IMAP configuration for email inbox (#25789) [FIX] Active users count on `@all` and `@here` (#25957) [FIX] Autotranslate method should respect setting (#26549) Chore: Remove italic/bold font-style from system messages (#26655) Chore: Convert AppSetting to tsx (#26625) Chore: Remove & Test old closeChat templates (#26631) [IMPROVE] General federation improvements (#26150) [NEW] Warn admins about running multiple instances of the monolith (#26667) Regression: Prevent message from being temp forever (#26668) Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) ...
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Kevin Aleman <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The primary change here has been to make the library try and reconnect after some time, up to a certain configured number of times, on a few different error classes.
Issue(s)
Steps to test or reproduce
Enable Omnichannel, select something as livechat routing strategy.
Administration -> Users -> click your username -> make sure your e-mail is verified.
Administration -> Email Inbox -> NEW -> fill everything up -> Save
Test the email by clicking on the arrow icon, and checking if it arrives on your email.
If it does, send an e-mail to the configured e-mail from another e-mail account.
The e-mail should arrive as a new visitor with a little envelope icon on the sidebar.
Click on the new visitor -> Reply via email -> type something and press enter
The response should arrive on the visitor's email.
Further comments
Email can be finicky to get working, so here a few specific tricks to get it to run:
gmail: enable 2-factor-authentication, enable an app password called 'Rocket.Chat', and use that as the password on the inbox.
outlook: really dislikes our SMTP SSL connection, SSL must be disabled to work with outlook/office365.
This list is compatible with our SMTP library https://nodemailer.com/smtp/well-known/ and provides working configurations for known hosts, comparing it with this list https://www.arclab.com/en/kb/email/list-of-smtp-and-imap-servers-mailserver-list.html makes it easier to test different email services.
P.S.: Other e-mail providers may need app passwords like gmail does.