[NEW] Added GET/POST channels.notifications #10128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcosSpessatto Amazing! Do you have the docs already? |
rodrigok
requested changes
Mar 15, 2018
| return RocketChat.API.v1.failure('The \'roomId\' param is required'); | ||
| } | ||
|
|
||
| const subscription = RocketChat.models.Subscriptions.findOneByRoomIdAndUserId(roomId, this.userId); |
There was a problem hiding this comment.
You can remove the fields in query, that will copy the object and remove the fields, example:
RocketChat.models.Subscriptions.findOne({}, {fields: {_room: 0, _user: 0, $loki: 0}});
| }; | ||
| const isInvalidNotification = !Object.keys(notifications).includes(field); | ||
| const basicValuesForNotifications = ['all', 'mentions', 'nothing', 'default']; | ||
| const fieldsMustHaveBasicValues = ['emailNotifications', 'audioNotifications', 'mobilePushNotifications']; |
There was a problem hiding this comment.
Is this missing desktopNotifications?
tests/end-to-end/api/02-channels.js
Outdated
| }) | ||
| .end(done); | ||
|
|
||
| it('/channels.leave', async(done) => { |
There was a problem hiding this comment.
Why this it is inside the it('POST /channels.notifications', (done) => {?
…dation to channels.notifications
rodrigok
requested changes
Mar 15, 2018
| const { roomId } = this.requestParams(); | ||
|
|
||
| if (!roomId) { | ||
| return RocketChat.API.v1.failure('The \'roomId\' param is required'); | ||
| } | ||
|
|
||
| const subscription = RocketChat.models.Subscriptions.findOneByRoomIdAndUserId(roomId, this.userId); | ||
| const subscription = RocketChat.models.Subscriptions.findOne({}, {fields: {_room: 0, _user: 0, $loki: 0}}); |
There was a problem hiding this comment.
Wrong find, please revert to the old one
rodrigok
approved these changes
Mar 26, 2018
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two endpoints: GET/POST channels.notifications, that returns and updates the notification settings from a specific channel. Requested in this issue.