Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Menu for changing push notification settings #288

Closed
TheReal1604 opened this issue Feb 15, 2017 · 9 comments · Fixed by #1396
Closed

[NEW] Menu for changing push notification settings #288

TheReal1604 opened this issue Feb 15, 2017 · 9 comments · Fixed by #1396
Assignees
Milestone

Comments

@TheReal1604
Copy link
Contributor

Menu for changing the push notification on a per channel basis is missing. I think the app gets the settings from the configured settings on the web?
image

@rafaelks
Copy link
Contributor

@TheReal1604 Yes, it does. But would be cool have it in the app. 👍

@rafaelks rafaelks changed the title [Feature Request] Menu for changing push notification settings Menu for changing push notification settings Feb 15, 2017
@rafaelks rafaelks modified the milestone: 1.0.4 Mar 9, 2017
@rafaelks rafaelks modified the milestone: 1.0.5 Mar 23, 2017
@rafaelks rafaelks changed the title Menu for changing push notification settings [NEW] Menu for changing push notification settings Oct 5, 2017
@artur-ios-dev
Copy link
Contributor

artur-ios-dev commented Mar 1, 2018

Should we show (allow changing) desktop notifications preferences section in our App as well?

@djschilling
Copy link

I also want to support this issue. Most users of our chat installation only use the mobile app to work with rocket.chat.

To change any of these settings they always have to go to the Desktop App or website. So most of them don't change it at all, and are frustrated to not get all messages as push.

@artur-ios-dev
Copy link
Contributor

artur-ios-dev commented Mar 5, 2018

I have started working on this feature but I do not have any ETA yet when I will finish that.

Btw. Is there a list of all possible settings? Settings API seems a little bit overwhelming to just get Account Notifications Preferences (would be so much cleaner to request only notifications settings). Also, how should I get notifications preferences for specific channel/room? Is it the same Settings API?

@rafaelks
Copy link
Contributor

rafaelks commented Mar 5, 2018

@djschilling @artrmz Thank you for your interest guys!

@MarcosSpessatto Can you please confirm if we have a REST API that returns and updates the notification settings from a specific channel?

@MarcosSpessatto
Copy link
Member

MarcosSpessatto commented Mar 13, 2018

@rafaelks, I opened this PR with the two endpoints. Please, take a look.

@artur-ios-dev
Copy link
Contributor

@MarcosSpessatto Awesome! What about global (user) notification's settings, do we have to use /api/v1/settings with a specific id? Is there maybe a list of all possible settings?

@rafaelks
Copy link
Contributor

@artrmz You mean, an API to fetch all the public settings? We already have that in the app... it's on AuthSettingsManager.swift.

@artur-ios-dev
Copy link
Contributor

@rafaelks Thanks, will check that out.

@rafaelks rafaelks added this to the 3.1.0 milestone Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants