Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic signal/property references #86

Merged
merged 10 commits into from
May 13, 2019
Merged

Conversation

josephbirkner
Copy link
Collaborator

@josephbirkner josephbirkner commented May 10, 2019

Changes acc. to #86:

  • §1 Signal can be constructed in with Module ... clause, module scope will be set automatically. Signal may be used as parameter signal=my_signal in state declaration
  • §2 Referring to signals by name should become illegal. The s(...) function will be removed. Refer either by exported module variable, or by the respective Property/State APIs.
  • §3 Setting Signal constraint properties like min_age, max_age, detached, will be moved from constructor parameters to chainable function calls: my_signal.min_age(30).detached(). Each function call returns a copy of the signal with the respective member value change.
  • §4 Properties will be referrable by symbols. The context's push/pop/setitem/getitem functions will be changed accordingly.
  • §5 It should be prevented, that developers call a property's read/write function directly. For this purpose, context should always adopt copies of the respective property objects. The originals will be untouched. An exception to this rule is generally made for child properties, since they mark an advanced use-case where properties are generally created dynamically, and usually accessed through their path anyway.
  • §6 The PropertyBase class will be renamed to Property.

josephbirkner and others added 2 commits May 8, 2019 01:29
signal parameter setting through chaining
use property objects instead of referencing by name
@codecov-io
Copy link

Codecov Report

Merging #86 into disco_demolition will increase coverage by 1.55%.
The diff coverage is 80%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           disco_demolition      #86      +/-   ##
====================================================
+ Coverage             75.13%   76.68%   +1.55%     
====================================================
  Files                    55       56       +1     
  Lines                  3334     3539     +205     
====================================================
+ Hits                   2505     2714     +209     
+ Misses                  829      825       -4
Impacted Files Coverage Δ
modules/ravestate_ui/ui_context.py 0% <0%> (ø) ⬆️
modules/ravestate_stalker/__init__.py 0% <0%> (ø) ⬆️
modules/ravestate_roboyio/__init__.py 0% <0%> (ø) ⬆️
modules/ravestate_ui/service.py 0% <0%> (ø) ⬆️
modules/ravestate_sendpics/__init__.py 0% <0%> (ø) ⬆️
modules/ravestate/__init__.py 100% <100%> (ø)
modules/reggol/colored_formatter.py 96.77% <100%> (+1.53%) ⬆️
modules/ravestate/spike.py 93.67% <100%> (-0.08%) ⬇️
modules/ravestate_fillers/__init__.py 100% <100%> (ø) ⬆️
modules/ravestate/state.py 96.96% <100%> (-0.97%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01d91a...c6689d8. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 12, 2019

Codecov Report

Merging #86 into disco_demolition will increase coverage by 1.65%.
The diff coverage is 79.26%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           disco_demolition      #86      +/-   ##
====================================================
+ Coverage             75.13%   76.79%   +1.65%     
====================================================
  Files                    55       56       +1     
  Lines                  3334     3568     +234     
====================================================
+ Hits                   2505     2740     +235     
+ Misses                  829      828       -1
Impacted Files Coverage Δ
modules/ravestate_ui/ui_context.py 0% <0%> (ø) ⬆️
modules/ravestate_stalker/__init__.py 0% <0%> (ø) ⬆️
modules/ravestate_roboyio/__init__.py 0% <0%> (ø) ⬆️
modules/ravestate_ui/service.py 0% <0%> (ø) ⬆️
modules/ravestate_sendpics/__init__.py 0% <0%> (ø) ⬆️
modules/ravestate/__init__.py 100% <100%> (ø)
modules/reggol/colored_formatter.py 96.77% <100%> (+1.53%) ⬆️
modules/ravestate/spike.py 93.67% <100%> (-0.08%) ⬇️
modules/ravestate_fillers/__init__.py 100% <100%> (ø) ⬆️
modules/ravestate/state.py 96.96% <100%> (-0.97%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01d91a...47b1529. Read the comment docs.

@josephbirkner josephbirkner merged commit b862126 into disco_demolition May 13, 2019
@josephbirkner josephbirkner deleted the symbolic branch May 13, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants