-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbolic signal/property references #86
Conversation
…ties by their objects.
signal parameter setting through chaining use property objects instead of referencing by name
…nclature, reducing calls to s(..)
…ixed major leaking loop variable bug in CausalGroup.
Codecov Report
@@ Coverage Diff @@
## disco_demolition #86 +/- ##
====================================================
+ Coverage 75.13% 76.68% +1.55%
====================================================
Files 55 56 +1
Lines 3334 3539 +205
====================================================
+ Hits 2505 2714 +209
+ Misses 829 825 -4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## disco_demolition #86 +/- ##
====================================================
+ Coverage 75.13% 76.79% +1.65%
====================================================
Files 55 56 +1
Lines 3334 3568 +234
====================================================
+ Hits 2505 2740 +235
+ Misses 829 828 -1
Continue to review full report at Codecov.
|
Changes acc. to #86:
Signal
can be constructed inwith Module ...
clause, module scope will be set automatically. Signal may be used as parametersignal=my_signal
in state declarations(...)
function will be removed. Refer either by exported module variable, or by the respective Property/State APIs.min_age
,max_age
,detached
, will be moved from constructor parameters to chainable function calls:my_signal.min_age(30).detached()
. Each function call returns a copy of the signal with the respective member value change.PropertyBase
class will be renamed toProperty
.