Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wildtalk punctuation #80

Closed
josephbirkner opened this issue Mar 21, 2019 · 2 comments
Closed

Fix wildtalk punctuation #80

josephbirkner opened this issue Mar 21, 2019 · 2 comments
Labels
bug 🪲 Something isn't working telegram 💌

Comments

@josephbirkner
Copy link
Collaborator

Currently, the roboy_parlai generative model adds spaces before every punctuation character. This looks weird. It should be fixed.
@josephbirkner josephbirkner added bug 🪲 Something isn't working telegram 💌 labels Mar 21, 2019
@l-laura
Copy link
Collaborator

l-laura commented Mar 21, 2019

This could help: https://ideone.com/hGXsx7

@josephbirkner josephbirkner mentioned this issue Apr 23, 2019
Merged
15 tasks
@josephbirkner
Copy link
Collaborator Author

Fixed with #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲 Something isn't working telegram 💌
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josephbirkner @l-laura