Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LTS node v10 #309

Merged
merged 3 commits into from
Jan 28, 2019
Merged

Use LTS node v10 #309

merged 3 commits into from
Jan 28, 2019

Conversation

viktorku
Copy link
Member

@viktorku viktorku commented Jan 1, 2019

Do we want to still keep using kinetic?

@viktorku viktorku requested a review from jihoonl January 1, 2019 14:52
@jihoonl
Copy link
Member

jihoonl commented Jan 17, 2019

The majority are still using Kinetic. So I would prefer to keep the support of kinetic version. However, I am not sure whether we should keep node version as 4.x.x. @mvollrath @viktorku. I think you guys are the most experienced users and maintainers here. Feel free to move on if you both agree.

@mvollrath mvollrath self-requested a review January 25, 2019 04:05
mvollrath
mvollrath approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@mvollrath mvollrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Dockerfile is only used for building and maybe self-contained demos? If so, fine by me.

@jihoonl jihoonl merged commit 6760294 into develop Jan 28, 2019
@jihoonl jihoonl deleted the viktorku-patch-2 branch January 28, 2019 03:09
@viktorku viktorku mentioned this pull request Jan 28, 2019
Closed
k-aguete pushed a commit to k-aguete/roslibjs that referenced this pull request Oct 21, 2022
@J-Rojas
Label the scene node using the visual element's name (RobotWebTools#309)
edfc311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvollrath mvollrath mvollrath approved these changes

@jihoonl jihoonl Awaiting requested review from jihoonl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktorku @jihoonl @mvollrath